Problem/Motivation

Follow-up for #2407195: Move attachment processing to services and per-type response subclasses.

#2407195 introduced HtmlResponseAttachmentsProcessor, which handles attachments for HTML responses. Including #attached['http_header']. But FinishResponseSubscriber was also doing this!

Proposed resolution

Remove the duplication; remove the header handling from FinishResponseSubscriber.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

BETA EVAL:

Follow-up bugfix for major task.

CommentFileSizeAuthor
#1 2512382-1.patch1.53 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2512382-1.patch1.53 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Follow-up for #2407195 Headers being addd in two places » Follow-up for #2407195: #attached['http_header'] being added to Response in two places
Issue summary: View changes
Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

RTBC

This this case does not need tests, because it is a quick follow-up bugfix and b) that will hopefully be nicely re-factored in the near future (internal changes only).

Crell’s picture

Crell CreditAttribution: Crell as a volunteer commented

Concur! Thanks, Wim.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Related issues: +#2477223: Refactor _drupal_add_html_head, drupal_get_html_head, _drupal_add_html_head_link into the attachments processor, remove from common.inc.

+1 RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 59469bf and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 59469bf on 8.0.x 
    Issue #2512382 by Wim Leers: Follow-up for #2407195: #attached['...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.