forum.test has several assertions and a whole section starting with // Verify original forum taxonomy. commented out.

CommentFileSizeAuthor
#2 omgihateyou.patch9.01 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Component: forum.module » tests

moving to tests.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Component: tests » base system
Priority: Normal » Critical
Status: Active » Needs review
FileSize
omgihateyou.patch9.01 KB

This is a first pass. It doesn't attempt to fix any of the broken logic or improve the test coverage. Just makes comments wrap at 80 chars, fixes a couple of variable names, removes some commented out assertions, fixes grammar issues etc. etc.

If this goes in without too much mess, I may try to improve what's actually left over, but I've got no intention of posting a 50k patch to try to fix this up all in one go. And so if you're tempted to nitpick, please re-roll with changes, because I can't face looking at this more than once.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Component: base system » forum.module
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the code clean up and it looks good. I installed the patch and ran the forum tests and the tests still work, as confirmed by the bot.

RTBC.

Dries’s picture

Dries CreditAttribution: Dries commented

I ran the tests locally, and everything seems to work. Committed to CVS HEAD. Thanks catch.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.