We should allow 32x32 px icons as well as 16x16, since on high pixel density displays the "E" icon looks fuzzy, and custom uploaded icon get resized to 16x16 and look fuzzy.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelstein’s picture

Status: Active » Needs review
FileSize
688 bytes

Here you go!

Dave Reid’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work

Thank you @joelstein for providing this patch for 7.x-1.x, I'm sure others will find it useful and gives us a good starting point for a D8 patch. We'll have to commit this to 8.x-1.x first and then backport since this is a feature.

joelstein’s picture

Status: Needs work » Needs review
FileSize
569 bytes

Here you go. :)

Dave Reid’s picture

Woah, nice turnaround. I'll get this tested this weekend.

joelstein’s picture

Thanks, Dave! This is a sweet module. Good work.

slashrsm’s picture

Issue tags: +Media Initiative, +sprint, +Novice
Dave Reid’s picture

Status: Needs review » Fixed

Tested and committed to 8.x-1.x and 7.x-1.x!

  • Dave Reid committed 5f1cae1 on 7.x-1.x authored by joelstein
    Issue #2512146 by joelstein: Allow high pixel density "retina" icons
    

  • Dave Reid committed d809d19 on 8.x-1.x authored by joelstein
    Issue #2512146 by joelstein: Allow high pixel density "retina" icons.
    
joelstein’s picture

Thanks!

  • Dave Reid committed 5f1cae1 on 7.x-2.x authored by joelstein
    Issue #2512146 by joelstein: Allow high pixel density "retina" icons
    
slashrsm’s picture

Issue tags: -sprint

Status: Fixed » Needs work

The last submitted patch, 3: entity_embed-retina-icons-D8-2512146-3.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: entity_embed-retina-icons-D8-2512146-3.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.