Problem/Motivation

We don't have a maintainer for the DateTime module.

Proposed resolution

Add mpdonadio as a maintainer.

Remaining tasks

Discuss.
Do it.

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#1 add_mpdonadio_as-2504893-1.patch416 bytesmpdonadio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
FileSize
add_mpdonadio_as-2504893-1.patch416 bytes

Some of you may know me from the "lets nuke l() and url()" issues, views and routing related ones, and a few others. Lately I have been working on several DateTime and Timestamp issues and feel that I have a good understanding of datetime.module, timestamps, and generate date/time related functionality in 8.0.x, and would be a good fit as the module maintainer for datetime.module.

PS, @jhodgdon suggested that adding @pjonckiere as a co-maintainer for datetime.module would be a good idea, too, but I haven't been able to raise him yet.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

I am not voting because this is how I found out there is a DateTime module.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented

Ok, I'll vouch that Matt is highly competent. He has also been on a datetime tear. +1 from me.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

+1
He has been doing a lot recently with date and is a solid contributor to the drupal program as a whole.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

I'm in favor of this! @mpdonadio has done thoughtful and careful work on a number of difficult issues related to datetime stuff, and also was attentive to both technical and release management concerns at the menu link sprint back in January in NJ.

@mpdonadio, it would be good to confirm that you've read the core maintainer governance document and are prepared for the subsystem maintainer responsibilities in particular.

Thanks for all your great work, past, present, and future.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented

@xjm, yes, I have read the Governance document (and followed the discussions a few weeks ago that lead to the revisions) and understand what subsystem maintainer responsibilities would entail.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented

I'm happy to RTBC, unless we should wait on pjonckiere, as mentioned in the first comment?

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Assigned: Unassigned » Dries
Status: Needs review » Reviewed & tested by the community

RTBC based on #6. We can file a separate issue for pjonckiere if he is interested as well.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: add_mpdonadio_as-2504893-1.patch, failed testing.

Status: Needs work » Needs review

mpdonadio queued 1: add_mpdonadio_as-2504893-1.patch for re-testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented

The fail was

require(): Failed opening required '/var/lib/drupaltrs' (include_path='/var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/phpunit/php-text-template:/var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/phpunit/php-timer:.:/usr/share/php:/usr/share/pear')

on client #3048. Retesting.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

OH yes +2

@mpdonadio worked a lot on this area in the last week and months

  • Dries committed 16563fa on 8.0.x 
    Issue #2504893 by mpdonadio: Add mpdonadio as maintainer for DateTime...
Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed. @mpdonadio, thanks for all your work and stepping up to being a maintainer for this module!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.