Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
Problem/Motivation
According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is now deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create()
. When the entity type is variable, we should use \Drupal::entityManager()->getStorage($entity_type)->create($values);
.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal because it's just about code cleanup and good practices |
Prioritized changes | The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability) |
Disruption | This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent. |
Proposed resolution
Replace the deprecated call to entity_create()
by a proper call to <EntityType>::create()
.
Before:
entity_create('field_config', $field_values)->save();
After:
use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff-2503403-3-4.txt | 634 bytes | naveenvalecha |
#5 | 2503403-4.patch | 2.94 KB | naveenvalecha |
#3 | aggregator-2503403-3.patch | 3.55 KB | Mac_Weber |
#1 | replace_deprecated-2503403-1.patch | 3.75 KB | DuaelFr |
Comments
Comment #1
DuaelFrComment #2
DuaelFrAs @alexpott said in #2494775-8: Replace deprecated usage of entity_create('action') with a direct call to Action::create(), this issue and it's meta are now postponed to Drupal 8.1.
Comment #3
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedSome files do not exist anymore and patch does not apply. Rerolled.
Comment #4
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #5
naveenvalechaThanks @Mac_Weber!
We don't need this new line.
Comment #6
Mile23My IDE can't find occurrences of
entity_create('aggregator
, the patch looks appropriate, and the tests passed as of the 8th.Setting RTBC, and restarting the test so it can disagree if it needs to.
Comment #8
catchCommitted/pushed to 8.1.x, thanks!