Replace deprecated usage of entity_create used with variable entity types with a direct call to EntityManager::getStorage()->create()

Working

Updated the patch against the 8.1.x-dev version.
Please make a review on attached patch

there is already an meta issue for replacing entity_create #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
This may not be the duplicate ?

Patch in #8 does not apply.

Rerolled #8.
Hope it works.

Console output:
11:12:32 PHP Fatal error: Namespace declaration statement has to be the very first statement in the script in ./core/modules/system/src/Tests/Entity/EntityAutocompleteTest.php on line 8

However I checked the namespace and everything seems to be correct.
Any idea?

Update the patch with this change.
Hope it works.

@DuaelFr Thanks .

Thanks for the reroll.

+++ b/core/modules/config/src/Tests/ConfigEntityStaticCacheTest.php
@@ -45,7 +45,10 @@ protected function setUp() {
-    entity_create($this->entityTypeId, array('id' => $this->entityId, 'label' => 'Original label'))->save();
+    \Drupal::entityManager()

For tests you want to use $this->container to explicitly get ahold of the service container supplied by the test class, instead of using \Drupal.

The patch still applies, so no reroll is needed.

It just needs some work.

@Mile23 then we should use $this->container instead of \Drupal in all test present in the patch?
If so, maybe we should change the description given in this issue?

@Mile23 then we should use $this->container instead of \Drupal in all test present in the patch?

Heading up, yes exactly.

patch at #18 does not be applied.

error: while searching for:
      FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED
    );
    // Create the parent entity.
    $entity = entity_create($this->entityType, array('type' => $this->bundle));

    // Create the default target entity.
    $target_entity = entity_create('entity_test_string_id', array('id' => $this->randomString(), 'type' => $this->bundle));

error: patch failed: core/modules/system/src/Tests/Entity/EntityReferenceFieldTest.php:199
error: core/modules/system/src/Tests/Entity/EntityReferenceFieldTest.php: patch does not apply

The patch needs rework, please do so.

I'm getting at least one test failure (EntityAutocompleteTest) from #18, unassigning.

Now it needs a reroll again. :-)

We also need to swap out \Drupal:: and replace it with $this->container within tests.

And the entity.manager service is deprecated, and we want to use entity_type.manager instead.

So:

1. +++ b/core/modules/config/src/Tests/ConfigEntityStaticCacheTest.php
   @@ -45,7 +45,10 @@ protected function setUp() {
   -    entity_create($this->entityTypeId, array('id' => $this->entityId, 'label' => 'Original label'))->save();
   +    \Drupal::entityManager()
   +      ->getStorage($this->entityTypeId)
   +      ->create(array('id' => $this->entityId, 'label' => 'Original label'))
   +      ->save();
   

   In tests:

   $this->container->get('entity_type.manager')->getStorage($entityType)....

2. +++ b/core/modules/field/field.module
   @@ -292,7 +292,9 @@ function _field_create_entity_from_ids($ids) {
   -  return entity_create($ids->entity_type, $id_properties);
   +  return \Drupal::entityManager()
   +    ->getStorage($ids->entity_type)
   +    ->create($id_properties);
   

   And in a procedural context:

   /Drupal::entityTypeManager()->getStorage($entity_type)...

In other contexts, you'd use the injected container rather than \Drupal, but that doesn't appear to be a concern in this issue.

Thanks.

Rerolled #18 again :)

I will work to fix 1, 2 in #30.

Patch to fix 1 and 2 in #30.

I think that the error could be the "em" markup, this causes the function "getAutocompleteResult" does not return a result.

I'm right? Or I'm wrong?

@dimaro, after applying patch #35, traces of entity_create can still be found. Running a quick grep -nr "entity_create(" . should give a quick references of it. Uploading the log file of traces.

In the attached patch I am not covered entity_create('config_test'

Looking in a meta issue we can find the following issues:
#2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class

Usages of entity_create('config_test'):
#2641518: Replace deprecated usage of entity_create('config_test') with a direct call to ConfigTest::create()

Usages of entity_create('entity_test'):
#2669400: Replace deprecated usages of entity_create('type') with a direct call to <EntityType>::create()

So I think that #37 and #39 could be outside the scope in this issue.
@DuaelFr @Mile23 What do you think about that?

Sorry It was mistaken,

Correct, According to the scope. #35 +1 RTBC

Please review #35

Repost the patch #35.
Thanks @DuaelFr for your review.

RTBC again?

Once RTBC, always RTBC ;-) (at least if it's still the same patch...)

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!