Add a hook_requirements() warning if no opcode cache is enabled

+1.

There could be a module that alters away the warning for sites that dont are stuck or dont care.

For runtime, are we are talking about the system status report? If so, +1.

Submitting initial patch, however need suggestions for the following -

• In case OP Caching is already available, should we show the user (on admin/reports/status page) the type of OP cache installed in addition to the 'Enabled' status?
• In case we find that more than one OP caching is installed, should we alert about the same since this might cause server errors?

Thanks

In case OP Caching is already available, should we show the user (on admin/reports/status page) the type of OP cache installed in addition to the 'Enabled' status?

What about telling users, which don't have it installed, how to enable OP cache, like linking to some specific page.
Btw. http://php.net/manual/de/opcache.installation.php is not entirely 100% helpful

The cache that ought to be used depends on the PHP version. I could be wrong, but < 5.5 should use APC and >= 5.5 should use Zend Opcache.

#2296557: [policy] Require PHP 5.5

#6: you beat me to it by 8 minutes :D

What about telling users, which don't have it installed, how to enable OP cache, like linking to some specific page.
Btw. http://php.net/manual/de/opcache.installation.php is not entirely 100% helpful

In case we find that more than one OP caching is installed, should we alert about the same since this might cause server errors?

I agree with both of these comments. Linking to documentation will be helpful for users, as will informing on status if more then one OP cache is installed; perhaps the former warrants throwing another warning.

As per the Proposed Resolution:

We could also get a rough idea of the memory allocation required for standard profile and warn if it's under that too - since Drupal usually requires more than the default and especially APC hates having a full cache

The patch has not quite addressed this aspect of the issue yet, but other than that everything looks good!

Given #2296557-145: [policy] Require PHP 5.5, where Dries has decided to ship Drupal 8 with requiring PHP 5.5, this issue no longer needs to be fixed, because 5.5 ships with the OpCache extension enabled by default.

But… it's still possible to disable that extension. So… perhaps we should still do this?

Given #2296557-145: [policy] Require PHP 5.5, where Dries has decided to ship Drupal 8 with requiring PHP 5.5, this issue no longer needs to be fixed, because 5.5 ships with the OpCache extension enabled by default.

Its not only that, you can also just configure it and I think on ubuntu it hasn't been enabled by default.

We would save significant hassles with this I think.

This is a reworking of #3, now that APC is out of the picture.

In regard to the max-accelerated files side of it, 16228 as the minimum value to look for would makes sense.

Lets just get this bit in. I'd rather bikeshed other limits in a new issue.

If I disable opcache using

opcache.enable=0

in php.ini this still reports opcache as being on.

How DARE you actually check the patches? Ha ha. We need a new runtime test.

This one actually works!

opcache_get_status()['opcache_enabled'] == TRUE

The == TRUE part is superflous. Can be fixed on commit if cilefen doesn't get to it.

@moshe weitzman Thank you for reviewing.

Committed f617434 and pushed to 8.0.x. Thanks!

The current check is too demanding and as a consequence, doesn't allow to use more secure settings, like opcache.restrict_api protection, because it will in turn auto-disable opcache_get_status(). We should instead use the check Symfony already has in place:

'zend_opcache_enabled' => extension_loaded('Zend OPcache') && ini_get('opcache.enable'),

This allows to configure any restrictions the server admin wants to avoid data leaks (like paths to scripts between sites on the same system) which are available if you allow opcache_get_status() to satisfy Drupal current requirements.

In fact, we could even re-use the check we already have for the only opcache function used in core:

if (function_exists('opcache_invalidate')) {}

@omega8cc Good idea, but open a followup for this and refer to it here please. The reason is that similar syntax is used in #2421451: Drupal needs comments in opcache and we may as well fix them both.

@cilefen -- OK, I have created issue #2639878: Use less demanding check to see if OPcache is active