Remove SafeMarkup::set in ViewUI::renderPreview()

working on this as part of NHDevDays2

changed SafeMarkup::set to SafeMarkup::format in 4 places in renderpreview()

I'm sorry but this is kinda broken. Feel free to compare the two screenshots

In order to reproduce use drush vd in your drupal root and then preview a view.

fixed formatting issue identified in testing

Thank you!

For easier additional reviews it is nice to provide an interdiff, see https://www.drupal.org/documentation/git/interdiff

Thanks @leslieg and thanks @dawehner for the manual testing and screenshots. (Adding dawehner to the proposed issue credit.)

Looking at the code here, I think this markup should be added to render arrays instead of using SafeMarkup::format() to get it in there. There's already so much render array goodness being built in ViewUI::renderPreview(). Let's build it once and avoid early and nested sanitization, duplicated SafeMarkup entries, and unalterable markup.

Edit: I mean if you don't use the render API in a method called renderPreview(), where can you? :)

working on it

Ooops...patch had wrong file, fixed it

I have added markup to render arrays as suggested in #8 and removed SafeMarkup::format from the patch

Reviewed the patch and tested on a clean branch of HEAD and then with the patch that refactored the code per #8, screenshots below. All the concerns in that comment have been addressed and now use render arrays instead of SafeMarkup::format().

In order to test it I first enabled the following Views Live Preview Settings (Show the SQL query; Show performance statistics; Show other queries run during render during live preview). Then I previewed several views, including Content and Taxonomy as depicted in the screenshots. In each case the results visually and in the markup were identical.

HEAD:

PATCH 11:

Nice work @kgoel! This is much cleaner now. Thanks also @crowdcg for the manual testing.

This issue is a required part of resolving a critical issue, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x.

Removed the now unused use statement on commit:

diff --git a/core/modules/views_ui/src/ViewUI.php b/core/modules/views_ui/src/ViewUI.php
index 6abfecb..92b004d 100644
--- a/core/modules/views_ui/src/ViewUI.php
+++ b/core/modules/views_ui/src/ViewUI.php
@@ -7,7 +7,6 @@
 
 namespace Drupal\views_ui;
 
-use Drupal\Component\Utility\SafeMarkup;
 use Drupal\Component\Utility\Html;
 use Drupal\Component\Utility\Timer;
 use Drupal\Component\Utility\Xss;