Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Coming from #2499971: Tests are missing @coversDefaultClass annotations.
If a module defines tests that derive from UnitTestCase, if its tests do not follow some specific PHPDoc format (which has yet to be documented #2325985: No documentation about @group @coversDefaultClass @covers), the entire page at admin/config/testing blows up with a Drupal\simpletest\Exception\MissingSummaryLineException, even if that module is not enabled.
This behaviour was changed in #2422019: Don't use reflection for parsing test annotations.
From the issue summary there, I can understand why @group is required, because that's what we're basing our discovery on. Why must there be a summary/description though?
Can we just default this to an empty string instead, and kill MissingSummaryLineException?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | killing_the_entire-2500031-12.patch | 3.06 KB | cilefen |
| #10 | Screen Shot 2015-06-04 at 1.56.19 PM.png | 186.26 KB | cilefen |
| #10 | interdiff.txt | 1.34 KB | cilefen |
| #4 | Screen Shot 2015-06-04 at 10.38.38 AM.png | 226.33 KB | cilefen |
| #3 | killing_the_entire-2500031-3.patch | 3.11 KB | cilefen |
Comments
Comment #1
larowlanCould we fallback to the class name?
Comment #2
cilefen CreditAttribution: cilefen commentedComment #3
cilefen CreditAttribution: cilefen commentedThis uses the former exception message.
Comment #4
cilefen CreditAttribution: cilefen commentedI prefer this because it tells the developer "you didn't do something we expect should be done". But maybe a blank space would be obvious.
Comment #8
cilefen CreditAttribution: cilefen commentedComment #9
webchickIt's funny because I had to stare at that screenshot for multiple seconds to understand what you meant. :) I think a blank space in this case is actually better, because that would definitely stand out against the other noise in the table.
Comment #10
cilefen CreditAttribution: cilefen commentedComment #11
cilefen CreditAttribution: cilefen commentedOops - wrong patch, correct interdiff though.
Comment #12
cilefen CreditAttribution: cilefen commentedComment #13
webchickNice! That works for me. Sending over to alexpott though, since it was his patch that went in.
Comment #14
alexpottI can't remember why I coded it so strict... this change makes sense.
This is test only code and therefore permitted during the beta. Committed fbeaa7e and pushed to 8.0.x. Thanks!