Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Issue #2456025: PHP warnings in PHP 5.6 because of always_populate_raw_post_data ini setting broke InstallUninstallTest in PHP 7. See #2454439: [META] Support PHP 7 for more details.
Proposed resolution
We need an additional condition to not run this on PHP 7 since this ini setting no longer exists there.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#12 | add_condition_to_ignore-2496943-12.patch | 1.28 KB | stefan.r |
#12 | interdiff-10-12.txt | 892 bytes | stefan.r |
#10 | add_condition_to_ignore-2496943-10.patch | 1.28 KB | sasanikolic |
#10 | add_condition_to_ignore-2496943-10-interdiff.txt | 970 bytes | sasanikolic |
#3 | add_condition_to_ignore-2496943-3.patch | 682 bytes | sasanikolic |
Comments
Comment #1
bzrudi71 CreditAttribution: bzrudi71 commentedComment #2
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedComment #3
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedAdded the condition for ignoring PHP7.
Note: it might be easier to read if we use the comparing operator as the third argument to version_compare().
Comment #4
dawehnerDo you mind specifying how this would look like exactly? Its pretty good to read already.
Do you checked whether we have a test for that requirement? I guess no, and I'm also not sure how we would be able to check it.
Comment #5
BerdirThe note is already implemented, that's the change that the patch is doing.
I don't see how we can test this. #2456025: PHP warnings in PHP 5.6 because of always_populate_raw_post_data ini setting also got it without a test. To be sure that this is working, I'll re-run the InstallUninstallTest on php7 tonight.
Comment #6
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented- Major, because soft-blocking a critical
- Bug, because broken on PHP-7
Comment #7
stefan.r CreditAttribution: stefan.r commentedIn newer versions we don't have to set it as it has disappeared, so: s/PHP versions 5.6 and up/in PHP version 5.6/
In theory we could test this if we wrapped ini_get and the PHP_VERSION constant, such as in #2455455: Fix outdated Unicode requirements check, but indeed a test should not be needed
Comment #8
stefan.r CreditAttribution: stefan.r commentedComment #9
klausiComment #10
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedCorrected the comment about PHP 5.6+.
Comment #11
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedBack to RTBC, looks great!
Comment #12
stefan.r CreditAttribution: stefan.r commentedOne last nitpick
Comment #13
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedComment #14
webchickOnward, PHP7! :)
Committed and pushed to 8.0.x. Thanks!