Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The unit tester needs this. The patch only moves a few lines of code around so it's RTBC. I did check and things still work.
Comment | File | Size | Author |
---|---|---|---|
#5 | extensible_drupal_test_suite-249629-5.patch | 5.13 KB | floretan |
#4 | extensible_drupal_test_suite.patch | 2.88 KB | chx |
#3 | extensible_drupal_test_suite.patch | 2.89 KB | chx |
#2 | extensible_drupal_test_suite.patch | 2.89 KB | chx |
extensible_drupal_test_suite.patch | 2.45 KB | chx | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedAs a good habit, can we start adding some better PHPdoc to this code?
Comment #2
chx CreditAttribution: chx commentedYes.
Comment #3
chx CreditAttribution: chx commentedCrell did not like _foo. And I do not think we should really make that protected, so I just dropped an underscore.
Comment #4
chx CreditAttribution: chx commentedAlso I am warned that methodName should not be method_name.
Comment #5
floretan CreditAttribution: floretan commentedWhile reviewing I also fixed some comment style issues (most of which were not part of the patch). No functional changes.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.