User registration test doesn't set required variables [#249608]

The remaining failed test for user.module does not check that user-configurable timezones are enabled and that a default timezone is set.

Comment	File	Size	Author
#2	user.test.patch	1.54 KB	boombatower
#2
	user.test.patch	839 bytes	floretan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Dries CreditAttribution: Dries commented 22 April 2008 at 09:21

Do we already have an extended timezone test in user.test? If not, we could use one.

Comment #2

boombatower CreditAttribution: boombatower commented 28 April 2008 at 21:13

File	Size
user.test.patch	1.54 KB

There isn't an extended timezone test in user.test, but this is necessary in order for the registration test to pass. This was noted as an issue, but were never resolved.

The patch fixes the issue. There was also a mistake on the assertTrue (looks like a simple copy paste error). So I fixed that and removed extra spacing.

Thanks!

Comment #3

boombatower CreditAttribution: boombatower commented 28 April 2008 at 21:13

Status:

Needs review

» Reviewed & tested by the community

This has my +1.

Comment #4

floretan CreditAttribution: floretan commented 29 April 2008 at 01:11

Good catch on the assertTrue (it was probably converted from an assertEqual).

Most of the timezone-related features are in common.inc and the system module, so more extensive timezone tests should be associated with these files rather than user.module.