In binaries/pngcrush.inc you create a temporary file, then move it into place using the mv shell built-in. This appears to partially fail when using S3. The result is temporary files being left behind. I think the mv here should probably be replaced by file_unmanaged_move() or something that will respect the stream wrappers.

As a work-around, I've just patched that code to clean up temporary files, if they're left behind. Patch forthcoming.

CommentFileSizeAuthor
#1 imageapi_optimize-clean_up_temp_files-2495943-1.patch539 bytesergonlogic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Poetic Systems for Camden commented
FileSize
imageapi_optimize-clean_up_temp_files-2495943-1.patch539 bytes

Here's the patch to clean up the temp files.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Active » Fixed

Thanks for the patch, applied to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.