Problem/Motivation

In the beginning, there was MigrateDrupal6TestBase, and it was good. Then Drupal 7 migration development started, and we ran into tests breaking because there was no Drupal 7 base class to extend.

Proposed Resolution

Create MigrateDrupal7TestBase.

Remaining Tasks

Create the class and commit it.

CommentFileSizeAuthor
#1 2495755-1.patch770 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

Priority: Normal » Major
FileSize
770 bytes

Initial patch. Since this is a super-simple abstract base class, I'm not sure we need a test.

Upgrading this issue to major because it blocks other Drupal 7 migration work.

phenaproxima’s picture

Status: Active » Needs review
benjy’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/core/modules/migrate_drupal/src/Tests/d7/MigrateDrupal7TestBase.php
@@ -0,0 +1,24 @@
+  /**
+     * {@inheritdoc}
+     */

Formatting went a little wonky...

Otherwise I think this is RTBC.

Wim Leers’s picture

Shouldn't there be something using this?

phenaproxima’s picture

<Yoda>Oh, there will be!</Yoda> Virtually all the child issues of #2456259: [META] Drupal 7 to Drupal 8 Migration path will be using this.

cilefen’s picture

+1 for introducing the Yoda tag.

Wim Leers’s picture

+1

webchick’s picture

Status: Reviewed & tested by the community » Fixed

I was going to knock this back for improved documentation, since "Base class for Drupal 7 migration tests." on a class called "MigrateDrupal7TestBase" is rather "why, yes..." but I see this is a direct copy/paste of the MigrateDrupal6TestBase class which says exactly the same thing.

Not sure if it's worth a follow-up for that or not; both are very lean classes so not much to document there, at least yet, so the boilerplateness is somewhat understandable.

Fixed the indentation problems and...

Committed and pushed to 8.0.x. Thanks! Will be great to see those D7 migrations start to come in! :D

  • webchick committed 27acbbb on
    Issue #2495755 by phenaproxima: Create MigrateDrupal7TestBase
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.