Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In the beginning, there was MigrateDrupal6TestBase, and it was good. Then Drupal 7 migration development started, and we ran into tests breaking because there was no Drupal 7 base class to extend.
Proposed Resolution
Create MigrateDrupal7TestBase.
Remaining Tasks
Create the class and commit it.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2495755-1.patch | 770 bytes | phenaproxima |
Comments
Comment #1
phenaproximaInitial patch. Since this is a super-simple abstract base class, I'm not sure we need a test.
Upgrading this issue to major because it blocks other Drupal 7 migration work.
Comment #2
phenaproximaComment #3
benjy CreditAttribution: benjy at CodeDrop commentedFormatting went a little wonky...
Otherwise I think this is RTBC.
Comment #4
Wim LeersShouldn't there be something using this?
Comment #5
phenaproxima<Yoda>Oh, there will be!</Yoda> Virtually all the child issues of #2456259: [META] Drupal 7 to Drupal 8 Migration path will be using this.
Comment #6
cilefen CreditAttribution: cilefen commented+1 for introducing the Yoda tag.
Comment #7
Wim Leers+1
Comment #8
webchickI was going to knock this back for improved documentation, since "Base class for Drupal 7 migration tests." on a class called "MigrateDrupal7TestBase" is rather "why, yes..." but I see this is a direct copy/paste of the MigrateDrupal6TestBase class which says exactly the same thing.
Not sure if it's worth a follow-up for that or not; both are very lean classes so not much to document there, at least yet, so the boilerplateness is somewhat understandable.
Fixed the indentation problems and...
Committed and pushed to 8.0.x. Thanks! Will be great to see those D7 migrations start to come in! :D