Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2383871: Spellchecking Drupal - PHP
Beta phase evaluation
Issue category | Bug because this is about spelling mistakes. |
---|---|
Issue priority | Not critical because these are only 3 minor issues in the code. Also, the affected strings are not very exposed to the user (they are tests or it is not exposed at all) |
Unfrozen changes | Unfrozen because it only changes (translatable) strings and tests. |
Disruption | Not disruptive, fixing these 3 typos is not going to break anything |
Comment | File | Size | Author |
---|---|---|---|
#19 | follow_up_to-2494313-19.patch | 2.12 KB | sumitmadan |
#14 | follow_up_to-2494313-14.patch | 2.11 KB | sumitmadan |
#3 | 2494313-3.patch | 2.11 KB | Pere Orga |
#1 | 2494313.patch | 858 bytes | Pere Orga |
Comments
Comment #1
Pere OrgaComment #3
Pere OrgaAttached patch fixes 3 typos
Comment #4
AohRveTPV CreditAttribution: AohRveTPV commentedLooks correct. No functional implications for these changes.
Comment #5
xjmThanks! Guess a couple were missed.
As I said in #2383871-35: Spellchecking Drupal - PHP, we need to do a beta evaluation on normal and minor tasks. Edit: sorry, I should have provided references. See https://www.drupal.org/core/beta-changes and https://www.drupal.org/contributor-tasks/update-allowed-beta.
Comment #6
xjmComment #7
xjmAlso I'm concerned as to what this is actually changing -- where is this label used?
Comment #8
AohRveTPV CreditAttribution: AohRveTPV commentedPostponed per https://www.drupal.org/core/beta-changes.
Comment #9
Pere OrgaThis label was introduced in #2121299: Migrate in Core: Drupal 6 to Drupal 8 (patch https://www.drupal.org/files/issues/2121299.35.patch) as part of the provided mappings of the source and destination fields. The label does not come from migrate and migrate_d2d projects.
As there's currently no UI provided and I can't see the strings exposed via Drush, I guess this is currently not used (obviously the label may be useful to document the mapping).
Can you be more specific why do you think this should be postponed? To me it should be the same than #2383871: Spellchecking Drupal - PHP.
Trying to add beta evaluation.
Comment #10
Pere OrgaComment #11
Pere OrgaAdding #2494319: Follow up to Spellchecking Drupal - Comments as a related issue.
Comment #12
AohRveTPV CreditAttribution: AohRveTPV commentedI was just posting the following to correct myself:
Looks good to me. Setting back to RTBC.
Comment #14
sumitmadan CreditAttribution: sumitmadan commentedRerolled the patch with latest code.
Comment #17
Pere OrgaThanks sumitmadan.
Setting it to RTBC as per #12
Comment #19
sumitmadan CreditAttribution: sumitmadan at QED42 commentedFile path is changed. Rerolled against the latest code. :)
Comment #20
Pere Orga:)
Comment #21
alexpottCommitted d4047ab and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.
This is used on configuration translation forms. It's good to fix it.