Coming from #2473709: Do not use SERVER_NAME as default value for the site name.

I installed Drupal 8 through the GUI for the first time in awhile (in Firefox FWIW). It looks like this:

My site helper text

Despite reviewing the parent issue at Dev Days literally like a month ago, I nevertheless thought that "My site" was pre-entered text and so skipped down to "Site email address" field. Then when that showed "normal"-looking text I looked back at the Site name field and wondered, "Why is that textfield disabled?"

The textfield is not disabled, of course. It just has "placeholder" text in there that you're meant to write over. But since none of the other fields do, it confused me.

Additionally, if you make this mistake and attempt to submit the form without having filled in a site name.... nothing happens. No error message. Just your cursor bounces back to the required field you missed. Repeat until you've gone insane. ;) (This is likely some other problem, maybe specific to how Firefox handles HTML5 required attributes.)

But bottom line: I'm wondering if that "My site" placeholder text is doing more harm than good here. Of all the things we're going to try and "hint," I don't think "Site name" benefits that much.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Status: Active » Needs review
FileSize
675 bytes

If others agree, here is a patch.

webchick’s picture

And given that that's the fix, another advantage I guess is this would bring Standard profile inline with all other install profiles which will most likely not bother to set this placeholder text.

LewisNyman’s picture

I think we either have to start using placeholders consistently on this form (if not on all forms).

mgifford’s picture

Re-uploading patch for the bots.

mohit_aghera’s picture

FileSize
114.77 KB

Looks good to me.
Tested in firefox and chrome. Attached screenshot for chrome.
And yes, I too installed D8 through GUI after long time ;)

mohit_aghera’s picture

Status: Needs review » Reviewed & tested by the community
yoroy’s picture

I think it makes sense to remove it here.

The reasons this doesn't work well here could be that:

- It's the only one, which makes it look like a real value
- It's actually a passable value as in "sure, call it My site (for now)". Whereas an emailadress field that would have "your email adress" as a placeholder would probably not be seen as a real value

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed 71c28b2 on
    Issue #2494131 by webchick, mgifford, mohit_aghera, LewisNyman, yoroy:...

  • catch committed 0da9986 on
    Issue #2494131 by webchick, mgifford, mohit_aghera, LewisNyman, yoroy:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.