JSDoc for all remaining modules

You know, this patch does not do any harm, but rather make it actually possible to be parsed by jsdoc.
I mean you could iterate on the patch level, but I think it would be way more sane to iterate for such tasks on a per issue level.

If people agree with that, I think we should RTBC the other 2 ones as well.

1. +++ b/core/modules/block/js/block.js
   @@ -55,8 +64,8 @@
   -      var tableDrag = Drupal.tableDrag.blocks; // Get the blocks tableDrag object.
   -
   +      // Get the blocks tableDrag object.
   +      var tableDrag = Drupal.tableDrag.blocks;
          // Add a handler for when a row is swapped, update empty regions.
   

   I'm curious, is there something like inline type comments like /** @var \Drupal... $foo in PHP

2. +++ b/core/modules/filter/filter.filter_html.admin.js
   @@ -37,6 +44,12 @@
   +   *
   +   * @todo Remove everything but 'attach' and 'detach' and make a proper object.
   +   */
   

   Do we have an issue for that todo?

You beat me to it :)

I was also looking through this now, and although I am not done looking, I agree with the view presented by @dawehner.

Also:

I'm curious, is there something like inline type comments like /** @var \Drupal... $foo in PHP

You can do stuff like /** @property {string} selector */ inline. Not sure how the output would be for Drupal jsDoc setup, but as a worst case, one can do it on several lines:

/**
  * @property {string} selector
  *   A selector.
  */
  var selector = '#some-long-id';

In theory. One would have to agree on a standard, though.

I'll look through the rest of the patch too, but looking good so far.

Thanks! Yes that's the approach we agreed to on the meta-issue. So the review on this and the other two should be something like "Is there anything blatantly wrong in this and can we verify it just adds/updates comments and not code". Thanks you two for doing this one!

OK, so that patch was quite the marathon. Did not check each and every variable and return value if it was actually the correct type, but as dawehner say, this is such a great start anyway.

A couple of things. Some very minor.

1. +++ b/core/modules/contextual/js/toolbar/views/AuralView.js
   @@ -7,16 +7,23 @@
   +     * Tracks whether the tabbing constraint announcement has been read once yet.
   

   Juuust 1 character too much :p

2. +++ b/core/modules/contextual/js/toolbar/views/VisualView.js
   @@ -30,7 +28,13 @@
   +     * Renders the visual view of the edit mode toggle. Listens to mouse & touch.
   

   81 characters :p

3. +++ b/core/modules/file/file.js
   @@ -124,14 +139,24 @@
   +     * @name Drupal.file.triggetUploadButton
   

   Typo. Should be triggeR not triggeT

4. +++ b/core/modules/locale/locale.admin.js
   @@ -73,10 +82,20 @@
   +    /**
   +     *
   +     * @return {string}
   +     */
   

   I see you have a lot of these. Is the extra new line before the @return to make room for other things?

5. +++ b/core/modules/tour/js/tour.js
   @@ -148,22 +197,21 @@
   +     * @example <caption>This will filter out tips that do not have a matching
   +     * page element or don't have the "bar" class.</caption>
   +     * http://example.com/foo?tips=bar
   

   Earlier in this file you had @example followed by a new line. Should be the norm IMO

6. +++ b/core/modules/tour/js/tour.js
   @@ -148,22 +197,21 @@
   +     * @see Drupal.tour.views.ToggleTourView#_getDocument()
   

   Should be something like @see {@link Drupal.tour.views.ToggleTourView#_getDocument} IMO. Just since we can. Although of course in this case, the link is like 250px above this one, but as a norm, I think we should use @link where possible.

7. +++ b/core/modules/views_ui/js/views-admin.js
   @@ -410,9 +525,10 @@
   +      // If the display has no contextual filters, hide the form where you
   +      // enter
   +      // the contextual filters for the live preview. If it has contextual
   +      // filters, show the form.
   

   Seems like a new line that stems from reformatting from 80 chars.

If no one bets me to it I'll upload an altered patch myself to make up for being the jerk that sets a RTBC issue to needs work ;)

Is there anything blatantly wrong in this and can we verify it just adds/updates comments and not code"

Hm, well there is nothing blatantly wrong I guess. And it does just add/update comments and not code. So please feel free to tell me if I am being too strict with setting to needs work here :)

Alright, let's ship it

awesome!

Most of this looks great! Obviously will need some more stuff filled in, but overall it adds a lot.

Follow-ups (besides generally filling stuff in):
- core/modules/field_ui/field_ui.js -- a bit off in places with wrapping and indentation, especially in - lists
- core/modules/views_ui/js/views-admin.js

58 files changed, 1157 insertions(+), 316 deletions(-)

Wow. that's a lot of work. Committed to 8.0.x. Thanks!