handleXmlrpcError() is only called inside the conditional blocks for system.connect and user.login. This means that if either of those calls produce an error, the failure is ignored, and the connection proceeds with the next step -- with almost certainly fatal results.
Comments
Comment #3
joachim commentedFixed on both branches.