Entity API docs incorrectly state hook_schema() is needed [#2491691]

According to https://api.drupal.org/api/drupal/core!modules!system!entity.api.php/gro...

> For content entities, the annotation will refer to a number of database tables and their fields. These annotation properties, such as 'base_table', 'data_table', 'entity_keys', etc., are documented on \Drupal\Core\Entity\EntityType. Your module will also need to set up its database tables using hook_schema().

This is no longer true, as can be seen with Node module for instance. Entity tables are no longer defined in hook_schema().

Novice task/proposed resolution

Take out the sentence that says you will need to set up the database tables.

Comment	File	Size	Author
#7	Fix_entity_api_doc_about_hook_schema_2491691-7.patch	831 bytes	marcoscano
#7

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 20 May 2015 at 16:13

Yeah, that changed and the docs need to be fixed.

Comment #2

jmolivas CreditAttribution: jmolivas at Blink Reaction (now part of FFW) commented 20 May 2015 at 17:00

Issue summary:

View changes

Fixing broken link to the docs

Comment #3

cilefen CreditAttribution: cilefen commented 20 May 2015 at 17:12

@jmolivas Please note in the issue summary if there are any tasks a novice can perform after you have looked it over.

Comment #4

cilefen CreditAttribution: cilefen commented 20 May 2015 at 17:13

@jmolivas Sorry, I misunderstood. Thank you for fixing the link.

Comment #5

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 20 May 2015 at 17:21

Issue summary:

View changes

I think all we need in the patch is for the sentence about hook_schema to be taken out.

Comment #6

cilefen CreditAttribution: cilefen commented 20 May 2015 at 17:41

Issue summary:

View changes

Comment #7

marcoscano

Portuguese, Brazil

Barcelona, Spain

CreditAttribution: marcoscano commented 22 May 2015 at 14:01

Status:

Active

» Needs review

File	Size
Fix_entity_api_doc_about_hook_schema_2491691-7.patch	831 bytes

Good novice task :)
Hope I didn't mess up with anything

Comment #8

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 22 May 2015 at 15:14

Status:

Needs review

» Reviewed & tested by the community

That's it, thanks!

Comment #9

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick at Acquia commented 25 May 2015 at 03:53

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed to 8.0.x. Thanks!

Comment #10

25 May 2015 at 03:54

webchick committed 74520b4 on 8.0.x

Issue #2491691 by marcoscano, cilefen, jhodgdon, joachim: Entity API...

Comment #12

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 25 May 2015 at 04:31

Hah. :) Legacy bit left over from our second-to-last beta blocker. This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks everyone!