Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Steps to Reproduce
Go to admin/structure/views/view/content
select Content: Publishing status (grouped)
Problem is most noticeable in FireFox
see image
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#20 | In RTL view.PNG | 85.5 KB | swati_qa |
#20 | After patch was applied.PNG | 87.51 KB | swati_qa |
#20 | Applied patch successfully.PNG | 86.1 KB | swati_qa |
#20 | Before patch.PNG | 85.61 KB | swati_qa |
#19 | text-layout-issue-views-2489660-19.patch | 385 bytes | AlviMurtaza |
Comments
Comment #1
ayang CreditAttribution: ayang commentedI was working with ijf8090 on this in the sprints at Drupalcon. Looks like some of the fields in the second column ("Field Identifier" and "Allow Multiple Selections") aren't being wrapped in the wrapper correctly. I'm guessing they're supposed to be in the second column?
Comment #2
ijf8090 CreditAttribution: ijf8090 as a volunteer commentedComment #3
dawehnerGood catch!
Did you tried creating a patch for this particular issue? https://www.drupal.org/node/707484 in case you need help how to create patches.
Comment #4
katzillaFor me it seems to be a CSS-Issue. The float of the right column (views-right-60) needs to be cleared. I'll try to find a way to clear this without destroying anything.
Comment #5
katzillaAdding a patch to fix this issue.
Comment #6
katzillaComment #7
dawehnerDo you mind posting an image of before/after in the issue summary?
Comment #8
katzillaHere are the screenshots:
LTR before Patch:
LTR after Patch:
RTL before Patch:
RTL after Patch:
Comment #9
katzillaComment #10
katzillaComment #11
lucur CreditAttribution: lucur commentedOn a fresh drupal-8 installation the views CSS is overridden by the stable theme CSS. I changed both files so that any element gets cleared, not only DIVs.
See #2575737: Copy templates, CSS, and related assets to Stable and override core libraries' CSS
Comment #12
swati_qa CreditAttribution: swati_qa commentedI tried reproducing the issue on Firefox, but it is displayed correctly on link http://localhost/drupal/admin/structure/views/view/content.
Screenshot has been attached for reference.
Comment #13
swati_qa CreditAttribution: swati_qa commentedComment #14
swati_qa CreditAttribution: swati_qa commentedComment #15
star-szrFrom what I can see this is a Firefox bug that was solved in Firefox 42. I was able to reproduce the behaviour only on Firefox 41 and earlier. The stable release as of this writing is 44.
I'm setting this back to needs review, I think this is a bit of a special case that needs more discussion, see also #2390621: [policy, no patch] Update Drupal's browser support policy.
@swati_qa from what you're saying you weren't able to reproduce this either - for future reference the "Reviewed & tested by the community" status shouldn't be used when the bug the patch is trying to solve can't be reproduced: https://www.drupal.org/node/156119#rtbc. Generally we would use "Closed (duplicate)" if the bug has been confirmed fixed or "Closed (cannot reproduce)" if the bug reported was never able to be reproduced (but this one was able to be reproduced at least at one point!).
Comment #16
swati_qa CreditAttribution: swati_qa commentedTested patch text_layout_issue_s-2489660-11.patch as mentioned in #11 for Firefox 41.
I was able to reproduce the issue there.
Steps followed:
1. Login as ADMIN.
2. Navigate to admin/structure/views/view/content
3. Select Content: Publishing status (grouped)
Screenshots have been attached for reference.
The issue still persists on Firefox 41 after patch was applied.
Also, issue is not reproducible on Firefox 44.
As patch fails testing, moving the issue to "Needs Work".
Comment #17
swati_qa CreditAttribution: swati_qa commentedComment #18
star-szr@swati_qa thanks for that testing!
Comment #19
AlviMurtaza CreditAttribution: AlviMurtaza as a volunteer and at Axelerant commentedAdding the fix.
Comment #20
swati_qa CreditAttribution: swati_qa commentedTested patch text-layout-issue-views-2489660-19.patch mentioned in #19 for Firefox 41.
Steps followed:
1. Login as ADMIN.
2. Navigate to admin/structure/views/view/content
3. Select Content: Publishing status (grouped)
Issue is working fine on Firefox 41.0 after patch was applied in RTL as well as LTR.
Screenshots attached for both views.
Issue is fixed for Firefox 41.0, so moving to RTBC.
Comment #21
swati_qa CreditAttribution: swati_qa commentedComment #22
alexpottIn #15 @Cottser wrote:
So do we fix this or not? Assigning to Cottser.
Comment #25
star-szrI like the fix in #19 more than the previous one and I don't see any harm/risk here so I think in this case we should fix it.
Committed and pushed f959540 to 8.2.x and f98c708 to 8.1.x. Thanks!