Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Against best practices, MachineName process plugin uses \Drupal::transliteration(). There doesn't appear to be any reason why it needs to do this.
Proposed Resolution
Inject the transliteration service in the create() method.
Remaining Tasks
SOP...patch, review, commit.
API/UI Changes
None!
Comment | File | Size | Author |
---|---|---|---|
#2 | 2488126-2.patch | 4.51 KB | phenaproxima |
#1 | 2488126-1.patch | 3.16 KB | phenaproxima |
Comments
Comment #1
phenaproximaComment #2
phenaproximaWhoops -- forgot to fix the unit test.
Comment #3
tim.plunkettI'm not sure how "inject things properly" fits into the beta evaluation, but this patch is correct. The diff looks like it changes transform() more than it does, here is what git diff shows me after applying the patch:
Comment #5
chx CreditAttribution: chx commented> I'm not sure how "inject things properly" fits into the beta evaluation, but this patch is correct.
Migrate is beta exempt. Thanks for the speedy review!
Comment #6
alexpottYep migrate is beta exempt. Committed f52cc18 and pushed to 8.0.x. Thanks!