Problem/Motivation

According to the coding standards methods should use lowerCamel naming. Some form classes in core doesn't respect this standard and use ::getFormID. Functions and methods in PHP are case-insensitive so this is not an issue but be consistent and follow standards in core would be a good thing

Proposed resolution

Rename the remaining ::getFormID to ::getFormId

Remaining tasks

Make a patch

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 rename_the_remaining-2485983-1.patch13.63 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Active » Needs review
FileSize
rename_the_remaining-2485983-1.patch13.63 KB
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Issue tags: +Coding standards
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 3d2b223 and pushed to 8.0.x. Thanks!

  • alexpott committed 3d2b223 on 8.0.x 
    Issue #2485983 by willzyx: Rename the remaining {Form}::getFormID to {...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.