Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Issue tags: +Novice, +JavaScript

Thanks :)

ram4nd’s picture

Assigned: Unassigned » ram4nd
ram4nd’s picture

There are no code changes just documentation changes. Also some other changes in the project, but those are not being bundled to Drupal.

ram4nd’s picture

Assigned: ram4nd » Unassigned
Status: Active » Needs review
ram4nd’s picture

Forgot "core.libraries.yml".

iMiksu’s picture

I've added also the LICENSE.md file from same version of the library.

diff --git a/core/core.libraries.yml b/core/core.libraries.yml
index dd8eae7..d9cba3c 100644
--- a/core/core.libraries.yml
+++ b/core/core.libraries.yml
   license:
     name: GNU-GPL-2.0-or-later
-    url: https://github.com/RobLoach/jquery-once/blob/master/LICENSE.md
+    url: https://github.com/RobLoach/jquery-once/blob/2.0.1/LICENSE.md
     gpl-compatible: true
   js:
     assets/vendor/jquery-once/jquery.once.min.js: { weight: -19, minified: true }
nikita.izotov’s picture

Tested, everything is working fine after patching.

nikita.izotov’s picture

Status: Needs review » Reviewed & tested by the community

Changing the status also

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

I did manual diffs to github - nothing unexpected. Usually I would require a beta evaluation to be added to the issue summary to commit a normal task. But this is a straight JS upgrade so going ahead with the commit. Committed 3006322 and pushed to 8.0.x. Thanks!

diff --git a/core/assets/vendor/jquery-once/jquery.once.js b/core/assets/vendor/jquery-once/jquery.once.js
old mode 100755
new mode 100644
diff --git a/core/assets/vendor/jquery-once/jquery.once.min.js b/core/assets/vendor/jquery-once/jquery.once.min.js
old mode 100755
new mode 100644

Fixed the file perms on commit - not changed by this patch but file perms of 755 are wrong.

  • alexpott committed 3006322 on 8.0.x
    Issue #2485605 by ram4nd, iMiksu: Update jquery.once to 2.0.1
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.