Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Proposed commit message
Issue #2485573 by nod_, alanburke, iMiksu: Update JS library domready to version 1.0.8
Original report
Current version: 1.0.7
New version: 1.0.8
Comment | File | Size | Author |
---|---|---|---|
#11 | 2485573-11-ab.patch | 2.93 KB | alanburke |
#7 | 2485573-7-update-domready.patch | 3.95 KB | ragnarkurm |
#2 | 2485573-2-update-domready.patch | 3.42 KB | alanburke |
Comments
Comment #1
nod_When updating include the minified file, the original source and the source map file (if any supplied by the lib).
Comment #2
alanburke CreditAttribution: alanburke at Annertech commentedUpdated to new version, and source file added.
Comment #4
iMiksuWe need to update the tests too at\Drupal\system\Tests\Common\AttachedAssetsTest::testVersionQueryString
EDIT: I figured out that it was actually changed, investigating now why failing.
Comment #5
iMiksuComment #6
iMiksuWe need to update the
core.libraries.yml
file. I haven't worked with external JS libraries before, so I'm not sure do we need to provide the source file by executing something?Comment #7
ragnarkurm CreditAttribution: ragnarkurm as a volunteer commentedComment #8
nikita.izotov CreditAttribution: nikita.izotov commentedTested, everything is ok
how i tested it manually:
Comment #9
alexpott@nod_ given that the minified is not minified should we be bothering to in the unminified file.
Comment #10
nod_Umm yeah, let's loose the unminified file for that one. I don't want to add the unminified version of modernizr or ckeditor or any other lib we don't have a map file for.
Comment #11
alanburke CreditAttribution: alanburke at Annertech commentedComment #12
nod_Thanks, all good.
Nice reduction in size with their new minification config.
Comment #13
Wim LeersWow, yes, significantly smaller!
Comment #14
alexpottCommitted 9489b81 and pushed to 8.0.x. Thanks!