Problem/Motivation

I ran into bizarre PHP errors and warnings while running the manifest file for testing the d6_upload migration. After several hours of poking at it, I realized that certain migrations were not being run in the correct order.

The d6_user_role migration is one of them -- it has an unmentioned dependency on the d6_filter_format migration. Why? Because d6_user_role invokes the filter_format_permission process plugin, which needs the d6_filter_format migration to have run. d6_filter_format, in turn, explicitly disallows stubbing of destination entities. So filter_format_permission ends up having no data to work with unless d6_user_role declares an explicit dependency on d6_filter_format.

Proposed Resolution

d6_user_role needs to declare an explicit dependency on d6_filter_format.

Remaining Tasks

RTBC and commit!

API Changes

None.

UI Changes

None.

CommentFileSizeAuthor
#2 2483479-2.patch540 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

Issue summary: View changes
phenaproxima’s picture

Title: Migrations must declare dependencies » d6_user_role migration depends on d6_filter_format
Issue summary: View changes
FileSize
540 bytes
phenaproxima’s picture

Status: Active » Needs review

Changing the status.

chx’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 944d3da on 8.0.x
    Issue #2483479 by phenaproxima: d6_user_role migration depends on...
alexpott’s picture

Can we get a followup issue to re-order MigrateDrupal6Test::$migrations so this and other dependencies are tested.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.