Problem/Motivation

Followup to #2456709: File views handlers need to be replaced with entity-aware formatters, we forgot to remove some stuff from the config schema of file.module.

Let's do it here.
Remove

  • -views.field.file_extension:
  • -views.field.file:
  • -views.field.file_filemime:
  • -views.field.file_uri:
  • -views.filter.file_status:

Steps to reproduce

Proposed resolution

Remove three of the schema, research in #16 and #18 showed that two are used, views.field.file and views.filter.file_status:

  • -views.field.file_extension:
  • -views.field.file_filemime:
  • -views.field.file_uri:

Remaining tasks

Review
Commit

CommentFileSizeAuthor
#12 2479607-12.patch1.23 KBquietone
#1 2479607.patch1.22 KBamateescu

Issue fork drupal-2479607

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2479607.patch1.22 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2479607.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Version: 8.9.x-dev » 9.2.x-dev
Status: Needs work » Needs review
Issue tags: +Bug Smash Initiative

My oh my, this patch still applies.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
2479607-12.patch1.23 KB

Same patch as in #1.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

There are 284 test failures. The ones I checked are errors in scheme so some, if not all, of the scheme entries being removed here are not obsolete.

Not sure what the next step here is. Leaving at NR.

sudiptadas19’s picture

sudiptadas19 CreditAttribution: sudiptadas19 at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Tested in Drupal 9.2.0-dev.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs review

@sudiptadas19, How did you test this patch?

In #13 I said that the testbot reports 284 test failures. They can be viewed at https://dispatcher.drupalci.org/job/drupal_patches/78043/.

Setting back to NR to decided on what the next step is here.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Status: Needs review » Needs work 
+++ b/core/modules/file/config/schema/file.views.schema.yml
@@ -4,39 +4,3 @@
-views.field.file:
-  type: views_field
-  label: 'File'
-  mapping:
-    link_to_file:
-      type: boolean
-      label: 'Link this field to download the file'

This one needs to stay in, that field plugin still exists and has a link_to_file option

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte commented
Title: Remove obsoleta schema entries from file.views.schema.yml » Remove obsolete schema entries from file.views.schema.yml

I've been checking each schema change and so far agree with @Lendude that is the one that I also see needs to stay.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte commented

I just noticed one thing I'm not sure about:

core/modules/file/config/optional/views.view.files.yml

plugin_id: file_status

@Lendude is this okay?

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented 
+++ b/core/modules/file/config/schema/file.views.schema.yml
@@ -4,39 +4,3 @@
-views.filter.file_status:
-  type: views.filter.in_operator
-  label: 'File status'

@Kristen Pol nice one! Yeah that needs to stay too. See \Drupal\file\Plugin\views\filter\Status

sudiptadas19 opened merge request !410

sudiptadas19’s picture

sudiptadas19 CreditAttribution: sudiptadas19 at QED42 for Drupal India Association commented
Status: Needs work » Needs review

Added suggested changes, available in MR410. Please Review.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes

I wasn't sure what the changes were so I made a comparison.

The original patch removed

  • -views.field.file_extension:
  • -views.field.file:
  • -views.field.file_filemime:
  • -views.field.file_uri:
  • -views.filter.file_status:

MR410 removes

  • -views.field.file_extension:
  • -views.field.file_filemime:
  • -views.field.file_uri:

The two removed were identified by lendude and Kristen Pol as being required.

So, that looks good.

I have updated the IS.

Anything more to do here to prove that these can be deleted?

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Status: Needs review » Reviewed & tested by the community

@quiteone, looks good to me. Rechecked these 3 again, and can find no use for them.

  • catch committed 13f1deb on 9.2.x 
    Issue #2479607 by sudiptadas19, quietone, amateescu, Lendude, Kristen...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 13f1deb and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.