Problem/Motivation

The XPaths in \Drupal\options\Tests\OptionsWidgetsTest::testEmptyValue() are very specific and this level of specificity is not needed to test this functionality. The specificity is causing failures in this test method when classes/markup are changed.

Proposed resolution

Make the XPath more agnostic about classes and markup.

Remaining tasks

  • Patch
  • Patch review

User interface changes

n/a

API changes

n/a

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, just simplifying the test to avoid failures
Issue priority Normal
Unfrozen changes Unfrozen because it only changes tests
CommentFileSizeAuthor
#1 2474107-1.patch1.47 KBstar-szr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Active » Needs review
Parent issue: » #2426781: Custom OptionWidget have no empty option label
FileSize
2474107-1.patch1.47 KB
yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

:-)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Thanks @Cottser.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Thank you both :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed e594f22 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed e594f22 on 8.0.x 
    Issue #2474107 by Cottser: Make OptionsWidgetsTest::testEmptyValue()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.