+++ b/core/lib/Drupal/Core/Asset/LibraryDiscovery.php
@@ -85,8 +69,6 @@ public function getLibrariesByExtension($extension) {
         // Allow modules and themes to dynamically attach request and context
         // specific data for this library; e.g., localization.

nit - We forgot to remove this comment, which is no longer true.

CommentFileSizeAuthor
#1 hook_library_alter-2474071-1.patch747 byteslauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Active » Needs review
FileSize
hook_library_alter-2474071-1.patch747 bytes
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Needs review » Reviewed & tested by the community

I can confirm that the patch is a quickfix that removes the comment leftover in the code.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Oops. :) Good catch!

This issue only changes code documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x

  • xjm committed 97b923b on 8.0.x 
    Issue #2474071 by lauriii: hook_library_alter() clean up
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +drupaldevdays

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.