Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The text field types where changed after the help text was committed. For example, there is on "Text" and "Long text" anymore, but "Text (plain)", "Text (formatted)" or "Text (plain, long".
Proposed resolution
Rewrite the Uses "Creating short/long text fields" and "Using text formaters and editors" to reflect the new text fields and the changed functionality.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff-8-10.txt | 3.53 KB | botris |
#12 | help-text-Text-Module-2471557-10.patch | 4.32 KB | botris |
#8 | text-patch.png | 41.77 KB | Reno Greenleaf |
#7 | interdiff-7.txt | 3.17 KB | joshi.rohit100 |
#7 | help-text-Text-Module-2471557-7.patch | 4.32 KB | joshi.rohit100 |
Comments
Comment #1
JinX-Be CreditAttribution: JinX-Be at Wunder commentedUpdated the help text
Comment #3
ifrikThanks JinX-Be,
it looks like you got two lines double at the end of your patch.
Comment #4
Reno Greenleaf CreditAttribution: Reno Greenleaf commentedHere is the patch with double lines removed.
Comment #5
dimaro CreditAttribution: dimaro at La Drupalera by Emergya commentedChange status to Needs review to run test.
Comment #6
jhodgdonLooks pretty good! One thing to fix:
We don't normally say "a or b or c" in English. It should be "a, b, or c" instead if there are 3 choices.
This occurs twice in the patch.
Comment #7
joshi.rohit100Done as per #6.
Comment #8
Reno Greenleaf CreditAttribution: Reno Greenleaf commentedThis last fix #7 looks good.
Comment #9
botrisThere where some missing comma's. It was A, B or C. But as we are using American English it should be A, B, or C.
Comment #10
ifrikThanks Boris Sondagh,
No more comma's missing.
Comment #11
jhodgdonNow there are too many commas.
In a list of 2, there should not be a comma.
So:
if you are using a or b, then do this. If you are using a, b, or c, do this.
Comment #12
botrisRemoved the commas in the lists of 2.
Comment #13
botrisComment #14
botrisand with interdiff...
Comment #15
ifrikThanks again,
now there is either no comma (a or b) or two commas (a, b, or c)
Comment #16
jhodgdonI would like to personally apologize for the strangeness of American English / Chicago Manual of Style punctuation rules, although I did not invent them. ;)
Thanks, looks good now!
Comment #17
webchickGreat, stuff, thanks! ;)
Committed and pushed to 8.0.x. Thanks!