Problem/Motivation

The text field types where changed after the help text was committed. For example, there is on "Text" and "Long text" anymore, but "Text (plain)", "Text (formatted)" or "Text (plain, long".

Proposed resolution

Rewrite the Uses "Creating short/long text fields" and "Using text formaters and editors" to reflect the new text fields and the changed functionality.

Remaining tasks

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JinX-Be’s picture

Status: Active » Needs review
FileSize
4.35 KB

Updated the help text

Status: Needs review » Needs work

The last submitted patch, 1: help-text-Text-Module-2471557-1.patch, failed testing.

ifrik’s picture

Thanks JinX-Be,

it looks like you got two lines double at the end of your patch.

Reno Greenleaf’s picture

Here is the patch with double lines removed.

dimaro’s picture

Status: Needs work » Needs review

Change status to Needs review to run test.

jhodgdon’s picture

Status: Needs review » Needs work

Looks pretty good! One thing to fix:

+++ b/core/modules/text/text.module
@@ -24,17 +24,17 @@ function text_help($route_name, RouteMatchInterface $route_match) {
+      $output .= '<dd>' . t('If you choose <em>Text (plain, long)</em> or <em>Text (formatted, long)</em> or <em>Text (formatted, long, with summary)</em> on the <em>Manage fields</em> page, then users can insert text of unlimited length. On the <em>Manage form display</em> page, you can set the number of rows that are displayed to users.') . '</dd>';

We don't normally say "a or b or c" in English. It should be "a, b, or c" instead if there are 3 choices.

This occurs twice in the patch.

joshi.rohit100’s picture

Status: Needs work » Needs review
FileSize
4.32 KB
3.17 KB

Done as per #6.

Reno Greenleaf’s picture

Issue summary: View changes
FileSize
41.77 KB

This last fix #7 looks good.
Screenshot

botris’s picture

Issue tags: +drupaldevdays
FileSize
4.33 KB
3.96 KB

There where some missing comma's. It was A, B or C. But as we are using American English it should be A, B, or C.

ifrik’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +drupaldevdays

Thanks Boris Sondagh,

No more comma's missing.

jhodgdon’s picture

Status: Reviewed & tested by the community » Needs work

Now there are too many commas.

In a list of 2, there should not be a comma.

So:

if you are using a or b, then do this. If you are using a, b, or c, do this.

botris’s picture

Removed the commas in the lists of 2.

botris’s picture

Status: Needs work » Needs review
botris’s picture

FileSize
3.53 KB

and with interdiff...

ifrik’s picture

Status: Needs review » Reviewed & tested by the community

Thanks again,

now there is either no comma (a or b) or two commas (a, b, or c)

jhodgdon’s picture

I would like to personally apologize for the strangeness of American English / Chicago Manual of Style punctuation rules, although I did not invent them. ;)

Thanks, looks good now!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Great, stuff, thanks! ;)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed ee798e5 on 8.0.x
    Issue #2471557 by Reno Greenleaf, boris sondagh, joshi.rohit100, JinX-Be...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.