Problem/Motivation

The bulk operation drop-down menu on the Content page /admin/content and the User Pages /admin/peopleis labelled "With selection".
This doesn't fit the function of this field, because it is not filtering anything (as it gives the impression), but it allows users to choose an action that they want to apply to the selected items.

default actions

Proposed resolution

Change the label.
Several solutions have been proposed:

  1. Select Action
    This option was downvoted because it doesn't match the language used for the other options (Published status, Language, etc.)
  2. Action
    However, folks pointed out that this doesn't reference that people need to select some content in order to perform the action selected.
  3. Removing the Label Altogether
    This would cause problems for screen readers, etc.
  4. Action > Apply to selection
    This was the last option proposed, and it seemed to address the concerns other folks expressed in the thread.

Remaining tasks

Contributor tasks needed
Task Complete?
Finalize the label wording
Update the patch

User interface changes

The changed wording needs to be changed in the hook_help text of the Node module. If still open, that can be taken up as part of #2470994: Update hook_help text for Node module

API changes

CommentFileSizeAuthor
#56 with-selection-after.png30.54 KBifrik
#53 interdiff-2471010-50-53.txt5.93 KBpguillard
#53 content_user_bulk_operations_label-2471010-53.patch15.97 KBpguillard
#50 interdiff-2471010-42-50.txt0 bytespguillard
#50 content_user_bulk_operations_label-2471010-50.patch9.8 KBpguillard
#48 interdiff-2471010-42-48.txt9.52 KBpguillard
#48 content_user_bulk_operations_label-2471010-48.patch12.67 KBpguillard
#42 interdiff-2471010-20-42.txt2.38 KBpguillard
#42 content_user_bulk_operations_label-2471010-42.patch2.16 KBpguillard
#36 apply-to-selection.png46.01 KByoroy
#21 select-action.png33.1 KByoroy
#20 2471010-content_user_bulk_operations_label-20.patch1.29 KBOleksiy
#13 Выделение_018.png15.23 KBandypost
#8 Выделение_017.png13.62 KBandypost
#4 2471010-4.patch1.33 KBBrolad
#1 screenshot-drupal8 nightingale 2015-04-14 18-16-35.png30.18 KBifrik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Title: Content bulk operation label does not fit the action » Lbel for Content and User bulk operations does not fit the action
Issue summary: View changes
FileSize
screenshot-drupal8 nightingale 2015-04-14 18-16-35.png30.18 KB
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Title: Lbel for Content and User bulk operations does not fit the action » Label for Content and User bulk operations does not fit the action
drubb’s picture

drubb
he/him
Primary language German
Location Sindelfingen
CreditAttribution: drubb commented

It's not easy, because it has to be some sort of combined text, including the possible selections. What about something like 'Select one or more items and..."

Brolad’s picture

Brolad CreditAttribution: Brolad at Skilld commented
FileSize
2471010-4.patch1.33 KB
Brolad’s picture

Brolad CreditAttribution: Brolad at Skilld commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented

IS mention about update hook_help for nodes, but node_help() said about "bulk operations"
So better wording also needed for help

jbguerraz’s picture

jbguerraz CreditAttribution: jbguerraz at Skilld commented

What about "Action:" ?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Issue summary: View changes
FileSize
Выделение_017.png13.62 KB

Updated IS with available actions

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Issue tags: +VDC, +Needs usability review
jaimeguzman’s picture

jaimeguzman CreditAttribution: jaimeguzman at Skilld commented

It has a lot of sense use only Select action, It can be easy to translate into other languages.

Status: Needs review » Needs work

The last submitted patch, 4: 2471010-4.patch, failed testing.

jbguerraz’s picture

jbguerraz CreditAttribution: jbguerraz at Skilld commented

Probably "List action:" would be better (the selection is the process that produce a list => here we already deal with a list).
List is enough abstract and clear to be used with any kind of views (people for instance).

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Issue summary: View changes
FileSize
Выделение_018.png15.23 KB

Another idea is to remove label completely because action names already contains "content" / "user(s)"
Also "Apply" button text could be used to rename...

Action already contains verb and target so it looks like "Process selected" should be enough

User's actions:

andypost queued 4: 2471010-4.patch for re-testing.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue tags: +Barcelona2015
DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented

@andypost I don't think we should entirely remove that label as it can be really valuable for people using a screen reader. We can still hide it visually, though.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
CreditAttribution: a.milkovsky as a volunteer commented

+1 for "Select action"

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Issue tags: -Needs usability review

Select action works, I dont think we should change the options.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Select action works, I dont think we should change the options.

Oleksiy’s picture

Oleksiy
Primary language Ukrainian
Location Lutsk 🇺🇦
CreditAttribution: Oleksiy at Skilld commented
Status: Needs work » Needs review
FileSize
2471010-content_user_bulk_operations_label-20.patch1.29 KB

Have updated patch to use "Select action" label.

yoroy’s picture

yoroy CreditAttribution: yoroy as a volunteer commented
Status: Needs review » Reviewed & tested by the community
FileSize
select-action.png33.1 KB

Tested on simplytest, looks good.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks,
"Select action" is a good label.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

This is a good improvement.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Version: 8.0.x-dev » 8.1.x-dev
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs review

So "with selection" indicated that in order to do anything you need to select content to perform the action on. If we look at the screenshot in #21 it looks as if by selecting an action from the list and clicking apply I would do that to whatever is listed. What is wrong with "Action to apply to selected content" where "content" is determined by the entity type. That also connects the selection to all the apply buttons on the screen.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Also "Select action" causes a disconnect because it looks like the screen is telling me to select an action... we don't have "Select language" for the language box above.

yoroy’s picture

yoroy CreditAttribution: yoroy as a volunteer commented
Status: Needs review » Needs work

Hmmm true. Thanks for the review. We'll need to come up with something better, probably a bit longer and more descriptive.

"With selected items" ?
"Apply the following action to the selected items" (too much but that's what we want to communicate, right?)

brahmjeet789’s picture

brahmjeet789 CreditAttribution: brahmjeet789 commented

To follow the same pattern as in previous boxes, "Published Status", "Type", "Title", "Language", should we label this as just "Action"?

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

"Action" sounds good.

That way we consistently got the description of the fields and what you can do with them:

  • Status, Type, Title, Language > Filter
  • Action > Apply

(I just noticed that that's opening another question as well: Can we shorten "Publication status" to "Status"? It only got "published" and "unpublished" anyway.)

yoroy’s picture

yoroy CreditAttribution: yoroy as a volunteer commented

"Action" might work indeed, lets do it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

The only issue with just "Action" is that we're missing the idea that you have to select some content for anything to occur - plus there's the fact that we have two apply buttons and the one at the end of the list can get a long way away from the drop-down to select the action to apply.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

So we actually got three items here:

  • the action, consisting out of the drop-down menu and its label
  • the button to apply the action and its label, above and below the list
  • and the list of content with tick boxes to select all or some of it, but without any label.

So maybe the reference to selection rather needs to go into the text of the button? If it's really needed, because we don't mention "selection" on the D7 content page either.

Action > Apply to selection

no_angel’s picture

no_angel CreditAttribution: no_angel as a volunteer commented
Issue tags: -Barcelona2015 +Needs issue summary update

- Barcelona2015
+ Needs Summary Update

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +Needs design
yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
FileSize
apply-to-selection.png46.01 KB

ifrik's #32 works very well I think:

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: +ux-interfacetext
lrmeeske’s picture

lrmeeske CreditAttribution: lrmeeske commented
Issue summary: View changes
Issue tags: -Needs issue summary update
brahmjeet789’s picture

brahmjeet789 CreditAttribution: brahmjeet789 commented

@Irmeeske: "Action" is not fit Label for Content and User bulk operations does not fit the action??

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: +DevDaysMilan

A patch for #32 would be useful here :)

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: Unassigned » pguillard
pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: pguillard » Unassigned
Status: Needs work » Needs review
FileSize
content_user_bulk_operations_label-2471010-42.patch2.16 KB
interdiff-2471010-20-42.txt2.38 KB

This is a patch for #32

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue tags: +sprint, +String change in 8.2.0

Thanks pguillard for the patch.

Since it's the wording I proposed: Could somebody else RTBC it?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Would it be "Apply to selected items" or "Apply to all selected" or something? "Apply to selection" sounds to me like it would change the *selection* itself, ie. reduce/expand which items are selected, not affect the items themselves but the "selection" of them. Foreign speaker here though....

Status: Needs review » Needs work

The last submitted patch, 42: content_user_bulk_operations_label-2471010-42.patch, failed testing.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Apply to selected items would be a good choice, because we often use "item" or on admin pages anyway.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: Unassigned » pguillard
pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: pguillard » Unassigned
Status: Needs work » Needs review
FileSize
content_user_bulk_operations_label-2471010-48.patch12.67 KB
interdiff-2471010-42-48.txt9.52 KB

Applied #46 (so #44) suggestion, and tests corrections.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Needs work

Hi,
it looks like you got two patches in one here.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
FileSize
content_user_bulk_operations_label-2471010-50.patch9.8 KB
interdiff-2471010-42-50.txt0 bytes

@ifrik, sorry, you are right (DDDs excitement maybe :-))

The last submitted patch, 48: content_user_bulk_operations_label-2471010-48.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 50: content_user_bulk_operations_label-2471010-50.patch, failed testing.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
FileSize
content_user_bulk_operations_label-2471010-53.patch15.97 KB
interdiff-2471010-50-53.txt5.93 KB

Should fix the last failing tests ..

Status: Needs review » Needs work

The last submitted patch, 53: content_user_bulk_operations_label-2471010-53.patch, failed testing.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
with-selection-after.png30.54 KB

Thanks pguillard,

That patch works now, and I think we now found a good wording for the button itself as well as in relation to the filter button above it. So this should be ready to go.

xjm credited ChandeepKhosa.

xjm credited pashupathi nath gajawada.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work

(Adding credit for contributors from the other issue.)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Reviewed & tested by the community

Oops, wrong issue! Sorry.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented

Credit.

  • 68649cf committed on 8.2.x 
    Issue #2471010 by pguillard, Arez, Oleksiy, ifrik, yoroy, andypost,...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Proposed changes look like an improvement to me!

Committed 68649cf and pushed to 8.2.x. Thanks!

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks so much everybody - this has been bugging me for so long, and now I can look at the Content page with a big smile :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint

Thanks, removing from UX sprint now.

brahmjeet789’s picture

brahmjeet789 CreditAttribution: brahmjeet789 as a volunteer and commented
brahmjeet789’s picture

brahmjeet789 CreditAttribution: brahmjeet789 as a volunteer and at gai Technologies Pvt Ltd commented