Mark \Drupal\Core\Template\TwigExtension::getUrlFromPath() as deprecated [#2470569]

Follow-up to #2425901: Remove calls to UrlGenerator->generateFromPath if possible

Problem/Motivation

UrlGenerator::generateFromPath() is deprecated, so the twig function using it also needs to be deprecated now and removed in the parent issue.

Proposed resolution

Mark method as deprecated.

Remaining tasks

API changes

Comment	File	Size	Author
#1	2470569-1.patch	615 bytes	pwolanin
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pwolanin CreditAttribution: pwolanin commented 14 April 2015 at 08:49

Status:

Needs work

» Needs review

File	Size
2470569-1.patch	615 bytes

Comment #2

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 14 April 2015 at 08:58

Status:

Needs review

» Reviewed & tested by the community

OK.

Comment #3

pwolanin CreditAttribution: pwolanin commented 14 April 2015 at 14:26

Issue tags:

+D8 Accelerate Dev Days

Comment #4

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 15 April 2015 at 08:01

Status:

Reviewed & tested by the community

» Fixed

Committed e7d2cd5 and pushed to 8.0.x. Thanks!

Comment #5

15 April 2015 at 08:02

alexpott committed e7d2cd5 on 8.0.x

Issue #2470569 by pwolanin: Mark \Drupal\Core\Template\TwigExtension::...

Comment #6

star-szr

he/him

English

CreditAttribution: star-szr commented 15 April 2015 at 20:55

Just want to mention that somewhere along the way we'll need a change record because anyone using the url_from_path Twig function will be in for a surprise otherwise and it will be hard to track down why things have broken for them.

Comment #7

pwolanin CreditAttribution: pwolanin commented 15 April 2015 at 21:52

@Cottser - so this just markes it deprecated, it's not removed, and dawehner suggested we could change the implementation if we want to keep a version in 8.0.0

Comment #8

star-szr

he/him

English

CreditAttribution: star-szr commented 15 April 2015 at 22:00

@pwolanin - thanks! Sorry, I should have been clearer in my comment, I understand this is just deprecating. My point was more that people working in templates won't be looking here to see if things are deprecated or not :)

And if we have a way of keeping the functionality then that makes my comment moot, the implementation details don't matter for what I'm talking about.