Problem/Motivation

Before #2033383: Provide a default plugin bag, FilterBase was passed the filter plugin collection (then called a "bag"). It was removed from the constructor but the property it was stored in remains.

Proposed resolution

Remove property

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#2 remove_obsolete-2470187-1.patch574 bytesmgifford
#1 remove_obsolete-2470187-1.patch574 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Active » Needs review
FileSize
remove_obsolete-2470187-1.patch574 bytes
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
remove_obsolete-2470187-1.patch574 bytes

Re-uploading patch for the bots.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 8.1.x-dev » 8.3.x-dev
Status: Needs review » Reviewed & tested by the community
YesCT’s picture

YesCT CreditAttribution: YesCT commented

@markdorison Thanks for reviewing this.

Adding some more information about what you do when you do a review helps the committers and future reviewers.
(https://www.drupal.org/patch/review)

I checked it still applies to 8.3.x.

Let's have the testbot run on 8.3.x.

I looked at the patch, it is pretty straight forward.
There are not un-intended coding style regressions (like maybe an extra or too few blank lines).

I also had phpstorm check and it reports there are no usages of the $collection property.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 7fd0693 and pushed to 8.3.x. Thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Assigned: Unassigned » alexpott
Status: Fixed » Reviewed & tested by the community

Looks like it didn't take.

  • alexpott committed 7fd0693 on 8.3.x 
    Issue #2470187 by tim.plunkett, mgifford: Remove obsolete FilterBase::$...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

It has now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.