Problem/Motivation

On the views edit field form (admin/structure/views/view/content > edit any field) The "remove" button should be a "danger" button.

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the button--danger class to the form element, so it looks like a danger button

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it doesn't meet usability standards
Issue priority Not critical because minor usability issue
Unfrozen changes Unfrozen because it only changes markup/
CommentFileSizeAuthor
#5 Screenshot 2015-04-13 17.09.42.jpg448.07 KBLewisNyman
#2 view_field_edit_form_remove_button_danger-2469933.patch518 bytesCauliflower
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented
Assigned: Unassigned » Cauliflower
Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented
FileSize
view_field_edit_form_remove_button_danger-2469933.patch518 bytes
Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented
Status: Active » Needs review
vpeltot’s picture

vpeltot CreditAttribution: vpeltot commented
Issue tags: +drupaldevdays 
+++ b/core/modules/views_ui/src/Form/Ajax/ConfigHandler.php
@@ -184,6 +184,7 @@ public function buildForm(array $form, FormStateInterface $form_state, Request $
+        '#button_type' => 'danger',

This change is OK for me.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Title: The view field edit form's remove should be styled a danger button » The view field edit form's remove should be styled as a danger button
Assigned: Cauliflower » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot 2015-04-13 17.09.42.jpg448.07 KB

Looks good to me! Thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9201dae and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 9201dae on 8.0.x 
    Issue #2469933 by Cauliflower: The view field edit form's remove should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.