Discovered in #2467101: Fix DialogTest outside apache/mod_php: don't send multiple Accept request headers.

In core/modules/simpletest/src/WebTestBase.php there are two "sister" functions that get and post AJAX requests, respectively.

One is called drupalGetAJAX() and the other is called drupalPostAjaxForm() which will cause any OCD person to light the world on fire. :P

The coding standards at https://www.drupal.org/node/608152#naming state:

If an acronym is used in a class or method name, make it CamelCase too (SampleXmlClass, not SampleXMLClass). [Note: this standard was adopted in March 2013, reversing the previous standard.]

So let's rename it drupalGetAjax() instead. AFAIK this should be a BC-compatible change.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Issue summary: View changes

Typo.

joshi.rohit100’s picture

Status: Active » Needs review
FileSize
7.53 KB

Done.

celdia’s picture

Renaming performed.
I appreciate this logical naming in Drupal 8.

googletorp’s picture

Status: Needs review » Reviewed & tested by the community

This looks good, RTBC imo.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

YAY! Thanks so much!

Committed and pushed to 8.0.x.

  • webchick committed ee12606 on 8.0.x
    Issue #2467887 by joshi.rohit100: Rename drupalGetAJAX to drupalGetAjax...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.