Deleting a profile field doesn't delete values in profile_values [#24678]

Comment	File	Size	Author
#13	del_profile_values_3.patch	1.84 KB	Richard Archer

#12	del_profile_values_2.patch	1.79 KB	Richard Archer

#7	del_profile_values_screen.png	14.14 KB	Richard Archer
#6	del_profile_values_1.patch	1.42 KB	Richard Archer

#3	del_profile_values.patch	867 bytes	DriesK

#1	profile_2.module	22.59 KB	jmengle

Comment #1

jmengle CreditAttribution: jmengle commented 9 June 2005 at 18:27

File	Size
profile_2.module	22.59 KB

Found where the field was deleted in profile.module and added a line to delete the field values from profile_values.

Log in or register to post comments

Comment #2

Uwe Hermann CreditAttribution: Uwe Hermann commented 22 August 2005 at 02:54

Can you please provide a proper patch?

Log in or register to post comments

Comment #3

DriesK CreditAttribution: DriesK commented 22 August 2005 at 13:39

Version:	4.6.0	» x.y.z
Status:	Active	» Needs review

File	Size
del_profile_values.patch	867 bytes

This is a patch of the db-cleanup code that jmengle added.

Log in or register to post comments

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 22 August 2005 at 14:16

Status:

Needs review

» Needs work

please provide big red warning to admins before they do this. this is a very destructive operation.

Log in or register to post comments

Comment #5

Bèr Kessels CreditAttribution: Bèr Kessels commented 22 August 2005 at 17:53

a default confirmation should do, imo.

Log in or register to post comments

Comment #6

Richard Archer CreditAttribution: Richard Archer commented 2 October 2005 at 07:52

Status:

Needs work

» Needs review

File	Size
del_profile_values_1.patch	1.42 KB

Here's a revised patch that:

cleans up field values when the field is deleted
provides the user with a better warning message
offers the suggestion to make the field hidden if the field data should be retained

I shall attach a screen grab on another post.

Log in or register to post comments

Comment #7

Richard Archer CreditAttribution: Richard Archer commented 2 October 2005 at 07:53

File	Size
del_profile_values_screen.png	14.14 KB

Screen grab of confirmation page.

Log in or register to post comments

Comment #8

Steve Dondley CreditAttribution: Steve Dondley commented 12 October 2005 at 03:13

you help text suggests making the fields hidden. How is it possible to make a profile field hidden?

Log in or register to post comments

Comment #9

Steve Dondley CreditAttribution: Steve Dondley commented 12 October 2005 at 03:19

Ah, OK, not hidden like a hidden HTML field. You'r talking about visibility setting in the profile module's field editing screen that says "Hidden profile field, only accessible by administrators, modules and themes."

I'd +1 this if you make that more clear and where this setting can be changed.

Log in or register to post comments

Comment #10

Richard Archer CreditAttribution: Richard Archer commented 12 October 2005 at 05:39

Assigned:

Unassigned

» Richard Archer

Hey Steve,

Thanks for having a look at this patch. And a BIG thank you for taking the time to work out what I was talking about in that help text :)

Here's a new patch that applies cleanly against HEAD. The old patch was hit by the new forms API.

I have improved the warning message that appears once you hit "delete". It now reads:

Are you sure you want to delete the field Example?
This action cannot be undone. If users have entered values into this field in their profile, these entries will also be deleted. If you want to keep the user-entered data, instead of deleting the field you may wish to edit this field and change it to a "hidden profile field".

The text "edit this field" is a link to the admin page where they can change the type of the field.