Problem/Motivation

This fixes two problems with PHP 7

* PHP 7 fatals when a method has two identical arguments. And we accidentally ended up with that in one place.

* The line in Sql.php is interpreted differerently in PHP 7, it tries to access the static property static::$info, apparently $this::$info is now a valid syntax for that?

Thought that creating two issues for one-line fixes for PHP 7 was a bit too much...

Proposed resolution

Fix them :)

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 php7-fatal-errors-2465009-1.patch1.79 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Priority: Normal » Major
Status: Active » Needs review
Parent issue: » #2454439: [META] Support PHP 7
FileSize
php7-fatal-errors-2465009-1.patch1.79 KB
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Reviewed & tested by the community

These look like sane fixes, even for php 5.4

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented

RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 9fdbd39 and pushed to 8.0.x. Thanks!

  • alexpott committed 9fdbd39 on 8.0.x 
    Issue #2465009 by Berdir: Fix fatal errors in rest and views with PHP 7

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.