PHP unit tests fail if intl extension is missing

no data loss, security, unusable system and the testbot does not fail on this, so not critical.

It only affects the documented system requirements for running phpunit tests, which is unfortunate but not a stop gap.

+++ b/core/modules/user/tests/src/Unit/Plugin/Validation/Constraint/ProtectedUserFieldConstraintValidatorTest.php
@@ -7,22 +7,21 @@
-  protected function getApiVersion() {
-    return Validation::API_VERSION_2_4;
+  protected function setUp() {
+    parent::setUp();
   }

empty setUp() method that just calls the parent and can be removed?

I don't see a problem with this.

In head when I run all the phpunit tests, I get

Fatal error: Class 'Locale' not found in /Users/ctheys/foo/drupal/core/vendor/symfony/validator/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php on line 85

with the patch I get

There was 1 error:

1) Drupal\Tests\Core\Image\ImageTest::testRotate
imagecolorallocatealpha() expects parameter 1 to be resource, null given

/Users/ctheys/foo/drupal/core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Rotate.php:60
/Users/ctheys/foo/drupal/core/lib/Drupal/Core/ImageToolkit/ImageToolkitOperationBase.php:177
/Users/ctheys/foo/drupal/core/lib/Drupal/Core/ImageToolkit/ImageToolkitBase.php:127
/Users/ctheys/foo/drupal/core/lib/Drupal/Core/Image/Image.php:148
/Users/ctheys/foo/drupal/core/lib/Drupal/Core/Image/Image.php:190
/Users/ctheys/foo/drupal/core/tests/Drupal/Tests/Core/Image/ImageTest.php:455

FAILURES!
Tests: 7631, Assertions: 40525, Errors: 1, Incomplete: 2.

Maybe that is just my local though?

Can anyone confirm/deny #8?

I changed my php version from PHP 5.5.14 to PHP 5.6.2
and then it ran fine.
Tests: 7631, Assertions: 40527, Incomplete: 2.

I can't reproduce this. On IRC YesCT mentioned doing a composer up so its possible she had some other code changes? At the very least the code in her failure is not related to this fix so i think its safe to handle separately if it is in fact reproducible.

Can't reproduce that fail, the patch fixes the Locale fatal error for me and everything else passes. @YesCT, can you open a new issue for that and report your exact PHP version and also the version of your gd extension?

$ php -i | grep "GD Version"
GD Version => 2.1.1-dev

sure thing.

#2464023: Move GD-specific code from Rotate::validateArguments() to Rotate::execute()

Great, let's get this one out of the way.

Committed and pushed to 8.0.x. Thanks!