Update to RingPHP to 1.0.7 which contains PHP7-related fixes for the issues Berdir found: https://github.com/guzzle/RingPHP/issues/22

Also update Guzzle from 5.0.3 to 5.2.0.

CommentFileSizeAuthor
#3 2461985-3.patch109.23 KBstefan.r
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Issue summary: View changes
stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Issue summary: View changes
stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Active » Needs review
FileSize
2461985-3.patch109.23 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Looks great!

We should also open a test issue to update to guzzle 6 to see how much work this would/could be.

amateescu’s picture

amateescu CreditAttribution: amateescu commented

Nice, this also contains my fix for older versions of cURL (https://github.com/guzzle/RingPHP/pull/12). Since nobody cared about the separate issue (#2248827: Notice: Use of undefined constant CURLOPT_TIMEOUT_MS), I'll just close it as a duplicate.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Note: There are still test failures in Guzzle itself on PHP7, but I don't know if there are any actual issues. Basic requests seem to work and we're not doing much more than that.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented

@Berdir do we need to fix the tests or fix Guzzle? If the latter, maybe we can first fix Guzzle, and ask for a 5.2.1 release and include that instead?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

We don't care much about failing guzzle tests. But I don't know if just tests are broken or parts of Guzzle that I haven't tested yet as well as the tests don't run through.

We can get this in but there's also no real urgency to do so I'd say. D8 won't run on PHP7 without manually removing the String class anyway. I think that @mtdowling will look into the remaining test failures soon.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

I've ensured that the patch does not introduce anything unexpected by doing the update myself. Committed ed89a08 and pushed to 8.0.x. Thanks!

This issue is a normal task so it should have a Drupal 8 beta criteria evaluation ie a Drupal 8 beta phase evaluation template to the issue summary. But this is allowable as a dependency update.

  • alexpott committed ed89a08 on 8.0.x 
    Issue #2461985 by stefan.r: Update Guzzle to latest release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.