SortArrayTest has hardcoded string comparison result values, but these can differ between PHP versions

Can we add a comment to that method that the exact values differ between PHP versions and are apparently considered an implementation detail, so that's it is not changed again two years later ;)

I've verified that this fixes 4 phpunit test fails that currently happen with PHP7. Comment looks good to me.

1. +++ b/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
   @@ -309,4 +309,28 @@ public function providerSortByTitleProperty() {
   +    if (!is_numeric($expected) || !is_numeric($result)) {
   +      return $this->assertTrue(FALSE, 'Parameters are not numeric.');
   +    }
   

   Do we need the is_numeric test? If we do need this test then $this->fail('Parameters are not numeric.'); is better. Also the return should be on a different line. Or even remove the if and just do $this->assertTrue(is_numeric($expected) && is_numeric($result), 'Some message');

2. +++ b/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
   @@ -309,4 +309,28 @@ public function providerSortByTitleProperty() {
   +    if (($expected < 0 && $result < 0) || ($expected > 0 && $result > 0) || ($expected === 0 && $result === 0))  {
   +      return $this->assertTrue(TRUE, 'Numbers are either both negative, both positive or both zero.');
   +    }
   +    $this->assertTrue(FALSE, 'Numbers are not either both negative, both positive or both zero.');
   

   This can be collapsed into a single assertion. I.e.

   $this->assertTrue(($expected < 0 && $result < 0) || ($expected > 0 && $result > 0) || ($expected === 0 && $result === 0), 'Numbers are not either both negative, both positive or both zero.');
   

That works too ;)

+++ b/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
@@ -324,13 +324,8 @@
+    $this->assertTrue(($expected < 0 && $result < 0) || ($expected > 0 && $result > 0) || ($expected === 0 && $result === 0), 'Numbers are not either both negative, both positive or both zero.');

I think the word "not" is incorrect. We are asserting the both number are both negative, both positive or both equal to 0.

Yep, language was wonky.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a87a166 and pushed to 8.0.x. Thanks!

diff --git a/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php b/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
index 7720e30..4411095 100644
--- a/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
+++ b/core/tests/Drupal/Tests/Component/Utility/SortArrayTest.php
@@ -319,9 +319,6 @@ public function providerSortByTitleProperty() {
    *   Expected comparison function return value.
    * @param int $result
    *   Actual comparison function return value.
-   *
-   * @return bool
-   *   TRUE if the assertion passed; FALSE otherwise.
    */
   protected function assertBothNegativePositiveOrZero($expected, $result) {
     $this->assertTrue(is_numeric($expected) && is_numeric($result), 'Parameters are numeric.');

The @return docs are not needed since we're not returning anything and PHPUnit assertions use exceptions anyway. Fixed on commit.