Problem/Motivation

Right now, ->original ends up in the last installed field storage definitions key value store.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 2459873-5.patch1.35 KBswentel
#2 2459873-2.patch666 bytesborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at iO commented
Assigned: Unassigned » borisson_
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at iO commented
FileSize
2459873-2.patch666 bytes

Unset the original key from the array.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at iO commented
Status: Active » Needs review
yched’s picture

yched CreditAttribution: yched commented

Grmble - any ConfigEntity can find itself having an 'original' property, so that would be yet another case for #1977206: Default serialization of ConfigEntities :-/

Meanwhile, for consistency at least within field config entities, can we add the same at least in FieldConfigBase::__sleep() ?

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2459873-5.patch1.35 KB
yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Thanks :-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed d3adcab and pushed to 8.0.x. Thanks!

I thought about requesting a test but it does not seem worth it.

  • alexpott committed d3adcab on 8.0.x 
    Issue #2459873 by borisson_, swentel: FieldStorageConfig::__sleep()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.