Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
BlockViewBuilder
currently only sets a block plugin's cache contexts if the block is cacheable.
This is wrong: cache contexts must always be set.
Proposed resolution
Fix it.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#5 | block_view_builder_cache_contexts-2458413-5.patch | 4.26 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #3
Wim LeersAnd voila, the expected test failure, proving that we indeed have test coverage for this.
Comment #4
Wim LeersSigh, I forgot to delete the original line below.
Comment #5
Wim LeersSuch a silly mistake.
Comment #6
Fabianx CreditAttribution: Fabianx commentedComment #7
alexpottThis issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed fd3a981 and pushed to 8.0.x. Thanks!