Problem/Motivation

Standard doesn't install for MongoDB cos taxonomy_views_data_alter makes $data['node_field_data'] exist.

Proposed resolution

View::isInstallable should check whether the base table is a base table (OK that sounds stupid but that's what's needed).

Note there is no test. The isInstallable mechanism has a test but writing a direct test against this would be so directly testing the implementation itself that it's completely pointless. For a real test, I recommend https://events.drupal.org/node/605 .

CommentFileSizeAuthor
#4 2456951_4.patch820 byteschx
2419059_redux.patch603 byteschx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Sound sane.

chx’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

This code looks like it needs a comment.

chx’s picture

Status: Needs work » Needs review
FileSize
820 bytes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

+1

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2456951_4.patch, failed testing.

Status: Needs work » Needs review

chx queued 4: 2456951_4.patch for re-testing.

chx’s picture

Status: Needs review » Reviewed & tested by the community

Bot fail.

Previous result: FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5271f8f and pushed to 8.0.x. Thanks!

  • alexpott committed 5271f8f on 8.0.x
    Issue #2456951 by chx: Impossible to enable views if entities are not in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.