Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Split off from #606840-32: Enable internal page cache by default:
With page cache on, and with cached pages in the page cache… if you turn on maintenance mode, anon users continue to see the site itself instead of the maintenance mode version. And much worse: when disabling maintenance mode, the site doesn't show up again :P
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2453351-8.patch | 2.13 KB | effulgentsia |
| #8 | 2453351-8-test-only.patch | 1.22 KB | effulgentsia |
| #1 | 2453351-1.patch | 1.01 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersI actually think this is critical; without this, Drupal 8 can appear completely broken.
Updated IS.
Comment #3
Fabianx CreditAttribution: Fabianx commentedLooks great!
We will have a test for this once, enable page cache by default is in.
Comment #4
dawehnerOh that was such a annoying problem in earlier versions of Drupal!!
Comment #5
webchickTalked this over with alexpott in IRC. Since this issue is fixing a critical, and the other is only a major task, we should copy in whatever test coverage uncovered this bug from that issue over here.
Comment #6
dawehnerWell, the test coverage is by enabling page caching for most tests.
Comment #7
Wim LeersPer #6.
Comment #8
effulgentsia CreditAttribution: effulgentsia at Acquia commentedI agree with #5: this could use explicit test coverage both with and without page cache, that is independent of what our default happens to be.
Here's the test addition for that. Leaving the issue at RTBC, because this only changes test code (the test-only patch is also the interdiff), that can be sufficiently sanity checked by whichever core committer looks at this. Plus, anything that slips through their review can be addressed in a non-critical follow-up.
Comment #9
BerdirRelated issue bump: #2429671: "The website has encountered an error. Please try again later." page is cached. If this is critical then the other one might be too?
Comment #12
webchickYeah, good point. Tentatively escalated that one to critical as well.
In the mean time, let's get this one out of the way. Thanks for the tests!
Committed and pushed to 8.0.x. Thanks!
Comment #13
Wim LeersLovely, thanks for the tests @effulgentsia!
Comment #15
pounardThis seem to happen with Drupal 7 too, can someone confirm ?
Comment #16
pounardI am sorry I shouldn't have changed the version.
Comment #17
Wim Leers@pounard: please open a new issue, and add this as a related issue.