The "Add language" button from this page "admin/config/regional/language/add" is missing it's '#button_type' property as "primary" making it with gray background instead of blue.

CommentFileSizeAuthor
#6 Add language - drupal8site.dd 2015-04-01 20-53-32.png30.35 KBnuwe
#6 button should be blue.png28.76 KBnuwe
#4 2452691-4-combined.patch1.77 KBvalthebald
#4 2452691-4-testonly.patch1.23 KBvalthebald
#2 add_language_button_property_2452691-2.patch558 bytesrosinegrean
#1 add_language_button_property-2452691-1.patch560 bytesrosinegrean
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean commented
Status: Active » Needs review
FileSize
add_language_button_property-2452691-1.patch560 bytes

Added the fix for this.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean commented
FileSize
add_language_button_property_2452691-2.patch558 bytes
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work
Issue tags: +Needs tests

The patch looks good, but we'll need test coverage I think. LanguageConfigurationTest seems to be a good place to add it.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
2452691-4-testonly.patch1.23 KB
2452691-4-combined.patch1.77 KB

Attached are 2 patches - one just adds a test if 'Add language' is a primary button (this one will fail), second one is a combination of test + patch

The last submitted patch, 4: 2452691-4-testonly.patch, failed testing.

nuwe’s picture

nuwe CreditAttribution: nuwe commented
Issue summary: View changes
FileSize
button should be blue.png28.76 KB
Add language - drupal8site.dd 2015-04-01 20-53-32.png30.35 KB

Thanks @valthebald for that patch I was actually confused with that part of how to assert the button belongs to that primary section but the patch you have looks good. the patch fixes the issue.I have uploaded both screen shots of the issue with and without the patch being applied.

nuwe’s picture

nuwe CreditAttribution: nuwe commented
Status: Needs review » Reviewed & tested by the community

I think the patch looks good and as you can see in the screenshots it resolves the issue

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 7cac6fa and pushed to 8.0.x. Thanks!

  • alexpott committed 7cac6fa on 8.0.x 
    Issue #2452691 by prics, valthebald: Missing button type property on "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.