Bundle cache is not invalidated after changing translation settings

Better solution... Tried reproducing and it works.

Patch from #2472373: Translation tab is not displayed when Book module has been enabled previously

Test looks good to me.

So this is a clear bugfix, and it makes sense to reset the cache after doing stuff. However, #2419649: Content translation schema updates are not triggered consistently moved the rebuild from the end of that submit handler up to its current location in HEAD. This reverts that. Can we look into why and at least document that we're not reverting something that the other issue didn't sufficiently test?

I've repeated the steps outlined in the issue summary of #2419649: Content translation schema updates are not triggered consistently and the fail reported in step 6 does not occur with this patch applied. Also that patch added a test which this is not causing to fail.

Thanks @alexpott.

+++ b/core/modules/content_translation/src/Tests/ContentTranslationContextualLinksTest.php
@@ -124,6 +116,17 @@ public function testContentTranslationContextualLinks() {
+    // Set up the node type and field to be translatable through the UI.

So the test coverage here relies on not clearing the cache programmatically in the test, and using the UI to do the configuration. Can we expand this comment to document this more clearly, so that someone in the future doesn't "optimize" things by converting this to API calls? (Since there are no assertions in the hunk.)

Sorry for not thinking of this in the previous review.

Sure np. And in fact we can remove more of the API calls than I originally saw.

Setting straight back to rtbc since only removing code from a test and adding a comment.

Sorry, the attached is what I meant. The comment addition in #12 still doesn't stop someone from removing the drupalPostForm() call to make the test faster (and it's a little confusing), but adding a comment right above the drupalPostForm() would. "Translatable through the UI" was also ambiguous and confused me on first read -- it is intended to mean "use the UI to make it translatable" but could be read as "make it so the UI can be used to translate it".

Same interdiff from #12, just with a non-bogus patch.

In #12 I introduced some parts of another patch :(

Thanks for fixing the comment @xjm.

+++ b/core/modules/content_translation/src/Tests/ContentTranslationContextualLinksTest.php
@@ -124,6 +110,18 @@ public function testContentTranslationContextualLinks() {
+    // Use a UI form sumission to make the node type and field translatable.

Shouldn't it be submission?

@jibran good spot.

More unrelated patch to remove. alexpott--

Thanks @alexpott for fixing the patch. Back to RTBC.

I don't know why my login is in the name of this patch, but @amateescu convinced me yesterday it's okay for me to commit it. Normal bugfix, so prioritized during the beta. Committed and pushed to 8.0.x, thanks!