Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

The focus of the issue is to remove usage of update_get_projects() from update.compare.inc

CommentFileSizeAuthor
#10 remove_usage_of-2449809-10.patch9.91 KBJeroenT
#10 interdiff.txt7.37 KBJeroenT
#5 remove_usage_of_update_get_projects-5.patch9.91 KBtadityar
remove_usage_of_update_get_projects.patch10.34 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Looks nothing left here

Status: Reviewed & tested by the community » Needs work

The last submitted patch, remove_usage_of_update_get_projects.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Needs reroll
tadityar’s picture

tadityar CreditAttribution: tadityar commented
Assigned: Unassigned » tadityar

I'm working on the reroll

tadityar’s picture

tadityar CreditAttribution: tadityar commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
remove_usage_of_update_get_projects-5.patch9.91 KB

Re-rolled

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Assigned: tadityar » Unassigned
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

a_thakur’s picture

a_thakur CreditAttribution: a_thakur at Srijan | A Material+ Company commented
Issue tags: +Needs change record

Could not find exiting change records, probably a new one has to be created.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Needs work

Thanks @a_thakur. Agreed that we need the change record first. When we create one, let's also add the original issue that added the update manager on it, since there might be other information missing from that change. So I think the title of the change record will be something like "Update manager service added..."

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented 
+++ b/core/modules/locale/locale.api.php
@@ -91,8 +91,9 @@
+ * by \Drupal\Update\UpdateManager->getProjects(). Using this hook, the data
+ * returned by \Drupal\Update\UpdateManager->getProjects() can be altered or

@@ -108,7 +109,7 @@
+ *   Project data as returned by \Drupal\Update\UpdateManager->getProjects().

Also, we should use ClassName::methodName() rather than ClassName->methodName() in documentation. Thanks!

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
FileSize
interdiff.txt7.37 KB
remove_usage_of-2449809-10.patch9.91 KB

Made changes as suggested by xjm in #9.

Patch attached.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Issue tags: -Needs change record

Created a draft change record: Update manager service added.

nit3ch’s picture

nit3ch CreditAttribution: nit3ch commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed f9f8b0d on 8.0.x 
    Issue #2449809 by JeroenT, tadityar: Remove usage of update_get_projects...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.