Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

The usage of the function is already removed in: https://www.drupal.org/node/2367743, this issue is to remove the function itself from form.inc

CommentFileSizeAuthor
#11 remove-drupal_form_submit-2448339-1.patch717 bytesMile23
#6 remove-drupal_form_submit-2448339-6.patch1.19 KBgaurav_varshney
#3 remove-drupal_form_submit-2448339-3.patch1.11 KBgaurav_varshney
#1 remove-drupal_form_submit-2448339-1.patch717 bytesa_thakur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Active » Needs review
FileSize
remove-drupal_form_submit-2448339-1.patch717 bytes

Please find the attached patch. Link added to change record as well: https://www.drupal.org/node/2121003

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Needs work

My IDE shows me a use of drupal_form_submit() in core/scripts/generate-d7-content.sh.

gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
Status: Needs work » Needs review
FileSize
remove-drupal_form_submit-2448339-3.patch1.11 KB

Status: Needs review » Needs work

The last submitted patch, 3: remove-drupal_form_submit-2448339-3.patch, failed testing.

a_thakur’s picture

a_thakur CreditAttribution: a_thakur at Srijan | A Material+ Company commented
Assigned: a_thakur » Unassigned
gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
Status: Needs work » Needs review
FileSize
remove-drupal_form_submit-2448339-6.patch1.19 KB
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Reviewed & tested by the community

My bad. I think generate-d7-content.sh is for use with a D7 site for various magical reasons which aren't spelled out very clearly.

I'm going to RTBC both #1 and #6, since they both still apply and both accomplish the goal.

If generate-d7-content.sh should be modified, then #6.

If it should *not* be modified, then #1.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Update: Definitely shouldn't change generate-d7-content.sh. :-)

So RTBC for #1.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can #1 be re-uploaded since only the latest patch is rtbc retested and can the CR which details the change to drupal_form_submit() have this issue added. Thanks.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Added the issue to the change record.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Needs review
FileSize
remove-drupal_form_submit-2448339-1.patch717 bytes

Re-uploading #1, which is the work of @a_thakur.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Reviewed & tested by the community

OK, so #1 is re-uploaded in #11, passes the testbot, has a reference in the change record, *and* does what this issue wants it to do. Therefore, RTBC. Credit to @a_thakur.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 6695db7 and pushed to 8.0.x. Thanks!

  • alexpott committed 6695db7 on 8.0.x 
    Issue #2448339 by a_thakur, gaurav_varshney, Mile23: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.