Problem/Motivation

The 'Custom Block' label appears in the UI as title case rather than sentence case ('Custom block'). It should be sentence case to match the other entity labels.

Proposed resolution

Fix it!

Before:

After:

CommentFileSizeAuthor
#4 content-block-label-2447819-4.patch1.32 KBpameeela
#1 content-block-label-2447819-1.patch717 bytespameeela
#1 Screen Shot 2015-03-07 at 2.41.47 pm.png35.43 KBpameeela
Screen Shot 2015-03-07 at 2.36.50 pm.png35.98 KBpameeela
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Assigned: pameeela » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
Screen Shot 2015-03-07 at 2.41.47 pm.png35.43 KB
content-block-label-2447819-1.patch717 bytes

Patch attached with updated screenshot

cafuego’s picture

cafuego CreditAttribution: cafuego commented

Tricky, the module that provides these is called 'Custom Block' internally, so there are other occurrences of the Title Cased Name.

However, they all refer to the module, so I *think* that this one is good to go when the test is green.

Status: Needs review » Needs work

The last submitted patch, 1: content-block-label-2447819-1.patch, failed testing.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
content-block-label-2447819-4.patch1.32 KB

Test fix

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Needs work » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Thank you

pameeela’s picture

pameeela CreditAttribution: pameeela commented

Thought I posted a reply to cafuego's comment, the module title should use title case, I checked this against other modules (e.g. Entity Reference). But seems the labels have a convention for sentence case (e.g. Taxonomy term).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed ba3813c and pushed to 8.0.x. Thanks!

  • alexpott committed ba3813c on 8.0.x 
    Issue #2447819 by pameeela: 'Custom Block' labels should use sentence...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.