I was wondering if there are any plans to make it possible to install the Owl library via drush. In the example of Colorbox, this drush command does so: drush colorbox-plugin

(example)

CommentFileSizeAuthor
#9 owlcarousel-using_drush_to_install-2445701-9.patch4.47 KBPlazik
#8 owlcarousel-using_drush_to_install-2445701-8.patch3.99 KBPlazik
#4 drush_support-2445701.patch2.94 KBNiklan
#3 drush_support-2445701.patch3.04 KBNiklan

Issue fork owlcarousel-2445701

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

knalstaaf’s picture

knalstaaf CreditAttribution: knalstaaf commented
Issue summary: View changes
swim’s picture

swim CreditAttribution: swim commented

Have a go at writing a patch yourself. Happy to help/ point you in the right direction by reviewing.

Niklan’s picture

Niklan
Primary language Russian
Location Russia, Perm
CreditAttribution: Niklan as a volunteer commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
drush_support-2445701.patch3.04 KB

I maked a patch which add drush command for download plugin and installing it.

Command is:

drush owlcarousel-plugin

Aliases:
drush owlcarousel-download
drush owl-download

Also, in additional. Drush will download plugin automatically if module is enabled via drush. This means:

drush en owlcarousel -y

is enough - plugin download automatically.

P.s. patch for 7.x-1.x branch

Niklan’s picture

Niklan
Primary language Russian
Location Russia, Perm
CreditAttribution: Niklan as a volunteer commented
FileSize
drush_support-2445701.patch2.94 KB

Use this pacth.

Niklan’s picture

Niklan
Primary language Russian
Location Russia, Perm
CreditAttribution: Niklan as a volunteer commented

Ane feedback? :(

swim’s picture

swim CreditAttribution: swim commented
Status: Needs review » Needs work

Hey Niklan,

Looks very similar to the Colorbox drush implementation - which is fine. However, I would rather see your own comments and instead of using a specific version reference this download link, http://owlgraphic.com/owlcarousel/owl.carousel.zip. We would hopefully always download the latest release (of the library) then.

Niklan’s picture

Niklan
Primary language Russian
Location Russia, Perm
CreditAttribution: Niklan as a volunteer commented

Hey, swin. Okay, thanks, i'll fix it.

Plazik’s picture

Plazik CreditAttribution: Plazik as a volunteer commented
Component: Miscellaneous » Code
Priority: Minor » Normal
Status: Needs work » Needs review
FileSize
owlcarousel-using_drush_to_install-2445701-8.patch3.99 KB

Added the new path. Changes from #4:

  1. Download the latest version from https://github.com/OwlFonk/OwlCarousel/archive/master.zip
  2. Added support to place library in custom directory (sites/site.com/libraries for example).
  3. Used drush temp dir to extact archive.
  4. Added drush make file.
Plazik’s picture

Plazik CreditAttribution: Plazik as a volunteer commented
FileSize
owlcarousel-using_drush_to_install-2445701-9.patch4.47 KB

I think the module shouldn't automatically download the library without user permission. I've updated the path and added:

  1. Question before downloading "Do you want to install Owl Carousel library in @path?"
  2. Question before deleting existing library "The folder "owl-carousel" in @path already exists. Do you want to delete and re-download it again?"
  3. New alias "owld"
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
Status: Needs review » Needs work

Feature requests for the 8.x-2.x branch only

Need to update the integration for Drupal 8 see https://git.drupalcode.org/project/colorbox/-/blob/8.x-1.x/drush/colorbo...

chakkche made their first commit to this issue’s fork.

chakkche opened merge request !3

chakkche’s picture

chakkche CreditAttribution: chakkche as a volunteer and at QED42 commented
Assigned: Unassigned » chakkche

I will work on this.

chakkche’s picture

chakkche CreditAttribution: chakkche as a volunteer and at QED42 for Drupal Association commented
Assigned: chakkche » Unassigned
Status: Needs work » Needs review

Created new drush command to install the libraries and changed the path in libraries.yml to downloaded path.

To test run drush owlcarousel2:plugin .

ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Needs review » Reviewed & tested by the community

  • ipwa committed d4bafa0 on 8.x-2.x authored by chakkche 
    Issue #2445701 by chakkche, Plazik, ipwa: Using drush to install the Owl...
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution :)

chakkche’s picture

chakkche CreditAttribution: chakkche as a volunteer and at QED42 for Drupal Association commented
Status: Fixed » Closed (fixed)
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Closed (fixed) » Fixed

Don't: Change the status of an issue from "Fixed" to "Closed (fixed)". An issue with the status "Fixed" will be automatically closed as fixed and removed from the list of open issues after 14 days. It should remain open for 14 days after being "Fixed" to cater for regressions and other unintended consequences of the fix.

From: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.