Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"
Remove functions:
- element_property()
- element_properties()
- element_child()
- element_children()
- element_get_visible_children()
- element_set_attributes()
bash-3.2$ grep element_set_attributes -nr *
core/includes/common.inc:1462:function element_set_attributes(array &$element, array $map) {
bash-3.2$
Comment | File | Size | Author |
---|---|---|---|
#18 | remove_element_from-2443805-18.patch | 3.03 KB | JeroenT |
#14 | remove-element-2443805-7.patch | 4.11 KB | a_thakur |
Comments
Comment #1
a_thakur CreditAttribution: a_thakur commentedComment #2
a_thakur CreditAttribution: a_thakur commentedPlease find the patch which removes the function.
Comment #3
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #4
alexpottPlease attached the relevant change record.
Comment #5
alexpottAlso please merge #2443793: Remove element_property() from common.inc and #2443807: Remove element_get_visible_children() from common.inc and remove the rest of the element_* from common.inc in this issue.
Comment #6
a_thakur CreditAttribution: a_thakur commentedPatch attached.
Comment #7
a_thakur CreditAttribution: a_thakur commentedComment #8
a_thakur CreditAttribution: a_thakur commentedLink added to relevant change records as well: https://www.drupal.org/node/2173683
Comment #10
a_thakur CreditAttribution: a_thakur commentedComment #13
daffie CreditAttribution: daffie commentedPostponed on #2226621: Remove usage of element_info(), element_child() and element_children(). Deprecate element_info_property()..
Comment #14
a_thakur CreditAttribution: a_thakur at Srijan | A Material+ Company commentedUsage have been fixed in https://www.drupal.org/node/2226621, please find the patch to delete the functions.
Comment #15
a_thakur CreditAttribution: a_thakur at Srijan | A Material+ Company commentedComment #16
JeroenTPatch looks good. All tests pass.
Comment #17
ianthomas_ukelement_info and element_info_property should not be removed since they were not deprecated in time (see the comment)
Beta evaluation on the meta, #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
Comment #18
JeroenTCreated new patch that removes the following functions:
Comment #19
andypostComment #20
Mile23Does in fact remove:
Also verified that those functions are marked for deprecation in 8.0.0.
Thus: +1 on RTBC.
Comment #21
catchCommitted/pushed to 8.0.x, thanks!